Skip to content

Commit f5fdd86

Browse files
committed
Make docker image testing locally easier
1 parent bd0f439 commit f5fdd86

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/docker/DockerBuildTask.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,12 @@ public void execute() {
222222
}
223223

224224
tags.forEach(tag -> spec.args("--tag", tag));
225-
226225
parameters.getBuildArgs().get().forEach((k, v) -> spec.args("--build-arg", k + "=" + v));
227226

228227
if (parameters.getPush().getOrElse(false)) {
229228
spec.args("--push");
229+
} else {
230+
spec.args("--load");
230231
}
231232
});
232233

build-tools/src/main/java/org/elasticsearch/gradle/Architecture.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
/**
1313
* TODO We need to clean that up when other (binary) components have aligned on architecture namings
14+
* I put all different names and nomenclatures here to have a central place to check when we adopt further
15+
* ones ml and beats have been updated and bwc branches have been updated too.
1416
* */
1517
public enum Architecture {
1618

0 commit comments

Comments
 (0)