Remove writeables from index options

Author: kderusso

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

@@ -38,9 +38,6 @@
 import org.apache.lucene.util.BytesRef;
 import org.apache.lucene.util.VectorUtil;
 import org.elasticsearch.common.ParsingException;
-import org.elasticsearch.common.io.stream.StreamInput;
-import org.elasticsearch.common.io.stream.StreamOutput;
-import org.elasticsearch.common.io.stream.Writeable;
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.util.FeatureFlag;
 import org.elasticsearch.common.xcontent.support.XContentMapValues;
@@ -1318,10 +1315,6 @@ public abstract static class DenseVectorIndexOptions implements IndexOptions {
             this.type = type;
         }
 
-        DenseVectorIndexOptions(StreamInput in) throws IOException {
-            this.type = in.readEnum(VectorIndexType.class);
-        }
-
         abstract KnnVectorsFormat getVectorsFormat(ElementType elementType);
 
         public boolean validate(ElementType elementType, int dim, boolean throwOnError) {
@@ -1389,11 +1382,6 @@ abstract static class QuantizedIndexOptions extends DenseVectorIndexOptions {
             super(type);
             this.rescoreVector = rescoreVector;
         }
-
-        QuantizedIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            this.rescoreVector = in.readOptionalWriteable(RescoreVector::new);
-        }
     }
 
     public enum VectorIndexType {
@@ -1716,16 +1704,6 @@ static class Int8FlatIndexOptions extends QuantizedIndexOptions {
             this.confidenceInterval = confidenceInterval;
         }
 
-        Int8FlatIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            confidenceInterval = in.readOptionalFloat();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new Int8FlatIndexOptions(in);
-        }
-
         @Override
         public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
             builder.startObject();
@@ -1773,15 +1751,6 @@ static class FlatIndexOptions extends DenseVectorIndexOptions {
             super(VectorIndexType.FLAT);
         }
 
-        FlatIndexOptions(StreamInput in) throws IOException {
-            super(in);
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new FlatIndexOptions(in);
-        }
-
         @Override
         public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
             builder.startObject();
@@ -1828,18 +1797,6 @@ public Int4HnswIndexOptions(int m, int efConstruction, Float confidenceInterval,
             this.confidenceInterval = confidenceInterval == null ? 0f : confidenceInterval;
         }
 
-        Int4HnswIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            m = in.readInt();
-            efConstruction = in.readInt();
-            confidenceInterval = in.readFloat();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new Int4HnswIndexOptions(in);
-        }
-
         @Override
         public KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -1912,16 +1869,6 @@ static class Int4FlatIndexOptions extends QuantizedIndexOptions {
             this.confidenceInterval = confidenceInterval == null ? 0f : confidenceInterval;
         }
 
-        Int4FlatIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            confidenceInterval = in.readFloat();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new Int4FlatIndexOptions(in);
-        }
-
         @Override
         public KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -1981,18 +1928,6 @@ public Int8HnswIndexOptions(int m, int efConstruction, Float confidenceInterval,
             this.confidenceInterval = confidenceInterval;
         }
 
-        Int8HnswIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            m = in.readInt();
-            efConstruction = in.readInt();
-            confidenceInterval = in.readFloat();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new Int8HnswIndexOptions(in);
-        }
-
         @Override
         public KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -2074,17 +2009,6 @@ static class HnswIndexOptions extends DenseVectorIndexOptions {
             this.efConstruction = efConstruction;
         }
 
-        HnswIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            m = in.readInt();
-            efConstruction = in.readInt();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new HnswIndexOptions(in);
-        }
-
         @Override
         public KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             if (elementType == ElementType.BIT) {
@@ -2145,17 +2069,6 @@ public BBQHnswIndexOptions(int m, int efConstruction, RescoreVector rescoreVecto
             this.efConstruction = efConstruction;
         }
 
-        BBQHnswIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            m = in.readInt();
-            efConstruction = in.readInt();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new BBQHnswIndexOptions(in);
-        }
-
         @Override
         KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -2210,15 +2123,6 @@ static class BBQFlatIndexOptions extends QuantizedIndexOptions {
             super(VectorIndexType.BBQ_FLAT, rescoreVector);
         }
 
-        BBQFlatIndexOptions(StreamInput in) throws IOException {
-            super(in);
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new BBQFlatIndexOptions(in);
-        }
-
         @Override
         KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -2274,17 +2178,6 @@ static class BBQIVFIndexOptions extends QuantizedIndexOptions {
             this.defaultNProbe = defaultNProbe;
         }
 
-        BBQIVFIndexOptions(StreamInput in) throws IOException {
-            super(in);
-            clusterSize = in.readVInt();
-            defaultNProbe = in.readVInt();
-        }
-
-        @Override
-        public IndexOptions readFrom(StreamInput in) throws IOException {
-            return new BBQIVFIndexOptions(in);
-        }
-
         @Override
         KnnVectorsFormat getVectorsFormat(ElementType elementType) {
             assert elementType == ElementType.FLOAT;
@@ -2323,14 +2216,10 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
         }
     }
 
-    public record RescoreVector(float oversample) implements ToXContentObject, Writeable {
+    public record RescoreVector(float oversample) implements ToXContentObject {
         static final String NAME = "rescore_vector";
         static final String OVERSAMPLE = "oversample";
 
-        RescoreVector(StreamInput in) throws IOException {
-            this(in.readFloat());
-        }
-
         static RescoreVector fromIndexOptions(Map<String, ?> indexOptionsMap, IndexVersion indexVersion) {
             Object rescoreVectorNode = indexOptionsMap.remove(NAME);
             if (rescoreVectorNode == null) {
@@ -2360,11 +2249,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
             builder.endObject();
             return builder;
         }
-
-        @Override
-        public void writeTo(StreamOutput out) throws IOException {
-            out.writeFloat(oversample);
-        }
     }
 
     public static final TypeParser PARSER = new TypeParser(

server/src/main/java/org/elasticsearch/index/mapper/vectors/IndexOptions.java

@@ -9,15 +9,9 @@
 
 package org.elasticsearch.index.mapper.vectors;
 
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.xcontent.ToXContent;
 
-import java.io.IOException;
-
 /**
  * Represents general index options that can be attached to a semantic or vector field.
  */
-public interface IndexOptions extends ToXContent {
-
-    IndexOptions readFrom(StreamInput in) throws IOException;
-}
+public interface IndexOptions extends ToXContent {}