Skip to content

Commit f790ff5

Browse files
committed
Align implementation with method name
1 parent b1ae833 commit f790ff5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/framework/src/main/java/org/elasticsearch/datageneration/matchers/source/DynamicFieldMatcher.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static org.elasticsearch.datageneration.matchers.Messages.prettyPrintCollections;
2525

2626
class DynamicFieldMatcher {
27+
private static final double FLOAT_ERROR_MARGIN = 1e-8;
2728
private final XContentBuilder actualMappings;
2829
private final Settings.Builder actualSettings;
2930
private final XContentBuilder expectedMappings;
@@ -77,7 +78,7 @@ public MatchResult match(List<Object> actual, List<Object> expected) {
7778
}
7879

7980
for (int i = 0; i < normalizedActual.size(); i++) {
80-
if (floatsEquals(normalizedActual.get(i), normalizedExpected.get(i))) {
81+
if (floatEquals(normalizedActual.get(i), normalizedExpected.get(i)) == false) {
8182
return noMatchSupplier.get();
8283
}
8384
}
@@ -99,8 +100,8 @@ private static List<Float> normalizeDoubles(List<Object> values) {
99100
return values.stream().filter(Objects::nonNull).map(toFloat).toList();
100101
}
101102

102-
private static boolean floatsEquals(Float actual, Float expected) {
103-
return Math.abs(actual - expected) > 1e-8;
103+
private static boolean floatEquals(Float actual, Float expected) {
104+
return Math.abs(actual - expected) < FLOAT_ERROR_MARGIN;
104105
}
105106

106107
private MatchResult matchWithGenericMatcher(List<Object> actualValues, List<Object> expectedValues) {

0 commit comments

Comments
 (0)