You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/package-info.java
+5-3Lines changed: 5 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -120,15 +120,17 @@
120
120
* Rerun the {@code CsvTests}. They should find your function and maybe even pass. Add a
121
121
* few more tests in the csv-spec tests. They run quickly so it isn't a big deal having
122
122
* half a dozen of them per function. In fact, it's useful to add more complex combinations
123
-
* of things here, just to catch any accidental strange interactions. For example, it is
124
-
* probably a good idea to have your function passes as a parameter to another function
123
+
* of things here, just to catch any accidental strange interactions. For example, have
124
+
* your function take its input from an index like {@code FROM employees | EVAL foo=MY_FUNCTION(emp_no)}.
125
+
* It's probably a good idea to have your function passed as a parameter to another function
125
126
* like {@code EVAL foo=MOST(0, MY_FUNCTION(emp_no))}. And likely useful to try the reverse
126
127
* like {@code EVAL foo=MY_FUNCTION(MOST(languages + 10000, emp_no)}.
127
128
* </li>
128
129
* <li>
129
130
* Now it's time to make a unit test! The infrastructure for these is under some flux at
130
-
* the moment, but it's good to extend from {@code AbstractScalarFunctionTestCase}. All of
131
+
* the moment, but it's good to extend {@code AbstractScalarFunctionTestCase}. All of
131
132
* these tests are parameterized and expect to spend some time finding good parameters.
133
+
* Also add serialization tests that extend {@code AbstractExpressionSerializationTests<>}.
132
134
* </li>
133
135
* <li>
134
136
* Once you are happy with the tests run the auto formatter:
0 commit comments