reuse bytesref

Author: dnhatn

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/TimeSeriesBlockHash.java

@@ -95,6 +95,7 @@ public void add(Page page, GroupingAggregatorFunction.AddInput addInput) {
         }
         try (var ordsBuilder = blockFactory.newIntVectorBuilder(tsidOrdinals.getPositionCount())) {
             final BytesRef spare = new BytesRef();
+            final BytesRef lastTsid = new BytesRef();
             final LongVector timestampVector = getTimestampVector(page);
             int lastOrd = -1;
             for (int i = 0; i < tsidOrdinals.getPositionCount(); i++) {
@@ -105,7 +106,8 @@ public void add(Page page, GroupingAggregatorFunction.AddInput addInput) {
                     if (positionCount() == 0) {
                         newGroup = true;
                     } else if (lastOrd == -1) {
-                        newGroup = lastTsid().equals(newTsid) == false;
+                        tsidArray.get(lastTsidPosition, lastTsid);
+                        newGroup = lastTsid.equals(newTsid) == false;
                     } else {
                         newGroup = true;
                     }
@@ -138,12 +140,6 @@ private void endTsidGroup() {
         }
     }
 
-    private BytesRef lastTsid() {
-        final BytesRef bytesRef = new BytesRef();
-        tsidArray.get(lastTsidPosition, bytesRef);
-        return bytesRef;
-    }
-
     @Override
     public ReleasableIterator<IntBlock> lookup(Page page, ByteSizeValue targetBlockSize) {
         throw new UnsupportedOperationException("TODO");