Skip to content

Commit fa41b6e

Browse files
authored
Migrate transport versions 8841050 through 8841041 (#135555)
This has an unusual case where we took a dead primary id and combined it with a patch only id for a change that removed a boolean in 8.19. This worked because the primary id was created prior to the 9.1.0 release, so this still guarantees compatibility with all upgrade paths. ES-12334
1 parent c6d1ede commit fa41b6e

File tree

24 files changed

+78
-67
lines changed

24 files changed

+78
-67
lines changed

modules/data-streams/src/main/java/org/elasticsearch/datastreams/options/action/GetDataStreamOptionsAction.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99
package org.elasticsearch.datastreams.options.action;
1010

11-
import org.elasticsearch.TransportVersions;
11+
import org.elasticsearch.TransportVersion;
1212
import org.elasticsearch.action.ActionRequestValidationException;
1313
import org.elasticsearch.action.ActionResponse;
1414
import org.elasticsearch.action.ActionType;
@@ -50,6 +50,10 @@ private GetDataStreamOptionsAction() {/* no instances */}
5050

5151
public static class Request extends LocalClusterStateRequest implements IndicesRequest.Replaceable {
5252

53+
private static final TransportVersion DATA_STREAM_OPTIONS_API_REMOVE_INCLUDE_DEFAULTS = TransportVersion.fromName(
54+
"data_stream_options_api_remove_include_defaults"
55+
);
56+
5357
private String[] names;
5458
private IndicesOptions indicesOptions = IndicesOptions.builder()
5559
.concreteTargetOptions(IndicesOptions.ConcreteTargetOptions.ERROR_WHEN_UNAVAILABLE_TARGETS)
@@ -95,7 +99,7 @@ public Request(StreamInput in) throws IOException {
9599
this.names = in.readOptionalStringArray();
96100
this.indicesOptions = IndicesOptions.readIndicesOptions(in);
97101
// This boolean was removed in 8.19
98-
if (in.getTransportVersion().isPatchFrom(TransportVersions.DATA_STREAM_OPTIONS_API_REMOVE_INCLUDE_DEFAULTS_8_19) == false) {
102+
if (in.getTransportVersion().supports(DATA_STREAM_OPTIONS_API_REMOVE_INCLUDE_DEFAULTS) == false) {
99103
in.readBoolean();
100104
}
101105
}

server/src/main/java/org/elasticsearch/TransportVersions.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -182,16 +182,6 @@ static TransportVersion def(int id) {
182182
public static final TransportVersion ML_INFERENCE_VERTEXAI_CHATCOMPLETION_ADDED_8_19 = def(8_841_0_38);
183183
public static final TransportVersion INFERENCE_CUSTOM_SERVICE_ADDED_8_19 = def(8_841_0_39);
184184
public static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES_ADDED_8_19 = def(8_841_0_40);
185-
public static final TransportVersion DATA_STREAM_OPTIONS_API_REMOVE_INCLUDE_DEFAULTS_8_19 = def(8_841_0_41);
186-
public static final TransportVersion JOIN_ON_ALIASES_8_19 = def(8_841_0_42);
187-
public static final TransportVersion ILM_ADD_SKIP_SETTING_8_19 = def(8_841_0_43);
188-
public static final TransportVersion ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY_8_19 = def(8_841_0_44);
189-
public static final TransportVersion ESQL_QUERY_PLANNING_DURATION_8_19 = def(8_841_0_45);
190-
public static final TransportVersion SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM_8_19 = def(8_841_0_46);
191-
public static final TransportVersion ML_INFERENCE_MISTRAL_CHAT_COMPLETION_ADDED_8_19 = def(8_841_0_47);
192-
public static final TransportVersion ML_INFERENCE_ELASTIC_RERANK_ADDED_8_19 = def(8_841_0_48);
193-
public static final TransportVersion NONE_CHUNKING_STRATEGY_8_19 = def(8_841_0_49);
194-
public static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES_ALLOW_LIST_8_19 = def(8_841_0_50);
195185
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0 = def(9_000_0_00);
196186
public static final TransportVersion REMOVE_SNAPSHOT_FAILURES_90 = def(9_000_0_01);
197187
public static final TransportVersion TRANSPORT_STATS_HANDLING_TIME_REQUIRED_90 = def(9_000_0_02);
@@ -251,11 +241,9 @@ static TransportVersion def(int id) {
251241
public static final TransportVersion REPO_ANALYSIS_COPY_BLOB = def(9_048_0_00);
252242
public static final TransportVersion AMAZON_BEDROCK_TASK_SETTINGS = def(9_049_0_00);
253243
public static final TransportVersion ESQL_REPORT_SHARD_PARTITIONING = def(9_050_0_00);
254-
public static final TransportVersion DEAD_ESQL_QUERY_PLANNING_DURATION = def(9_051_0_00);
255244
public static final TransportVersion DEAD_ESQL_DOCUMENTS_FOUND_AND_VALUES_LOADED = def(9_052_0_00);
256245
public static final TransportVersion DEAD_BATCHED_QUERY_EXECUTION_DELAYABLE_WRITABLE = def(9_053_0_00);
257246
public static final TransportVersion DEAD_SEARCH_INCREMENTAL_TOP_DOCS_NULL = def(9_054_0_00);
258-
public static final TransportVersion ESQL_QUERY_PLANNING_DURATION = def(9_055_0_00);
259247
public static final TransportVersion BATCHED_QUERY_EXECUTION_DELAYABLE_WRITABLE = def(9_057_0_00);
260248
public static final TransportVersion SEARCH_INCREMENTAL_TOP_DOCS_NULL = def(9_058_0_00);
261249
public static final TransportVersion COMPRESS_DELAYABLE_WRITEABLE = def(9_059_0_00);
@@ -282,18 +270,10 @@ static TransportVersion def(int id) {
282270
public static final TransportVersion ML_INFERENCE_VERTEXAI_CHATCOMPLETION_ADDED = def(9_083_0_00);
283271
public static final TransportVersion INFERENCE_CUSTOM_SERVICE_ADDED = def(9_084_0_00);
284272
public static final TransportVersion ESQL_LIMIT_ROW_SIZE = def(9_085_0_00);
285-
public static final TransportVersion ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY = def(9_086_0_00);
286273
public static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES = def(9_087_0_00);
287-
public static final TransportVersion JOIN_ON_ALIASES = def(9_088_0_00);
288-
public static final TransportVersion ILM_ADD_SKIP_SETTING = def(9_089_0_00);
289-
public static final TransportVersion ML_INFERENCE_MISTRAL_CHAT_COMPLETION_ADDED = def(9_090_0_00);
290-
public static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES_ALLOW_LIST = def(9_091_0_00);
291-
public static final TransportVersion SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM = def(9_092_0_00);
292274
public static final TransportVersion SNAPSHOT_INDEX_SHARD_STATUS_MISSING_STATS = def(9_093_0_00);
293-
public static final TransportVersion ML_INFERENCE_ELASTIC_RERANK = def(9_094_0_00);
294275
public static final TransportVersion SEARCH_LOAD_PER_INDEX_STATS = def(9_095_0_00);
295276
public static final TransportVersion HEAP_USAGE_IN_CLUSTER_INFO = def(9_096_0_00);
296-
public static final TransportVersion NONE_CHUNKING_STRATEGY = def(9_097_0_00);
297277
public static final TransportVersion PROJECT_DELETION_GLOBAL_BLOCK = def(9_098_0_00);
298278
public static final TransportVersion SECURITY_CLOUD_API_KEY_REALM_AND_TYPE = def(9_099_0_00);
299279
public static final TransportVersion STATE_PARAM_GET_SNAPSHOT = def(9_100_0_00);

server/src/main/java/org/elasticsearch/search/fetch/subphase/FetchSourceContext.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
package org.elasticsearch.search.fetch.subphase;
1111

1212
import org.elasticsearch.TransportVersion;
13-
import org.elasticsearch.TransportVersions;
1413
import org.elasticsearch.common.ParsingException;
1514
import org.elasticsearch.common.Strings;
1615
import org.elasticsearch.common.io.stream.StreamInput;
@@ -46,6 +45,9 @@ public class FetchSourceContext implements Writeable, ToXContentObject {
4645
public static final ParseField INCLUDES_FIELD = new ParseField("includes", "include");
4746
public static final ParseField EXCLUDES_FIELD = new ParseField("excludes", "exclude");
4847

48+
private static final TransportVersion SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM = TransportVersion.fromName(
49+
"search_source_exclude_vectors_param"
50+
);
4951
private static final TransportVersion SEARCH_SOURCE_EXCLUDE_INFERENCE_FIELDS_PARAM = TransportVersion.fromName(
5052
"search_source_exclude_inference_fields_param"
5153
);
@@ -157,8 +159,7 @@ public void writeTo(StreamOutput out) throws IOException {
157159
}
158160

159161
private static boolean isVersionCompatibleWithExcludeVectors(TransportVersion version) {
160-
return version.isPatchFrom(TransportVersions.SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM_8_19)
161-
|| version.onOrAfter(TransportVersions.SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM);
162+
return version.supports(SEARCH_SOURCE_EXCLUDE_VECTORS_PARAM);
162163
}
163164

164165
public boolean fetchSource() {
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# We have taken a donor primary id from
2+
# another collapsed primary id since
3+
# we only have a patch id here given that
4+
# this feature was removed in 8.19.
5+
# This works because our donor was taken
6+
# prior to 9.1.0 release. So this still
7+
# honors bwc from 8.19 -> 9.1 and
8+
# 9.0 -> 9.x.
9+
9081000,8841041
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9055000,8841045
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9086000,8841044
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9091000,8841050
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9089000,8841043
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9088000,8841042
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
9094000,8841048

0 commit comments

Comments
 (0)