[CI] Auto commit changes from spotless

Author: elasticsearchmachine

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/ChangePointOperator.java

@@ -38,7 +38,9 @@ public class ChangePointOperator implements Operator {
 
     public static final int INPUT_VALUE_COUNT_LIMIT = 1000;
 
-    public record Factory(int metricChannel, Optional<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn) implements OperatorFactory {
+    public record Factory(int metricChannel, Optional<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn)
+        implements
+            OperatorFactory {
         @Override
         public Operator get(DriverContext driverContext) {
             return new ChangePointOperator(driverContext, metricChannel, partitionChannel, sourceText, sourceLine, sourceColumn);
@@ -64,7 +66,14 @@ public String describe() {
 
     // TODO: make org.elasticsearch.xpack.esql.core.tree.Source available here
     // (by modularizing esql-core) and use that instead of the individual fields.
-    public ChangePointOperator(DriverContext driverContext, int metricChannel, Optional<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn) {
+    public ChangePointOperator(
+        DriverContext driverContext,
+        int metricChannel,
+        Optional<Integer> partitionChannel,
+        String sourceText,
+        int sourceLine,
+        int sourceColumn
+    ) {
         this.driverContext = driverContext;
         this.metricChannel = metricChannel;
         this.partitionChannel = partitionChannel;
@@ -128,7 +137,6 @@ private void createOutputPages() {
         }
         boolean tooManyValues = maxValuesCount > INPUT_VALUE_COUNT_LIMIT;
 
-
         List<MlAggsHelper.DoubleBucketValues> bucketValuesPerPartition = new ArrayList<>();
         boolean hasNulls = false;
         boolean hasMultivalued = false;
@@ -168,14 +176,14 @@ private void createOutputPages() {
                 }
             }
             // Handle last partition separately
-//        if (lastPartitionFieldValue != null) {
+            // if (lastPartitionFieldValue != null) {
             MlAggsHelper.DoubleBucketValues bucketValues = new MlAggsHelper.DoubleBucketValues(
                 null,
                 values.stream().mapToDouble(Double::doubleValue).toArray(),
                 bucketIndexes.stream().mapToInt(Integer::intValue).toArray()
             );
             bucketValuesPerPartition.add(bucketValues);
-//        }
+            // }
         }
 
         List<ChangeType> changeTypes = new ArrayList<>();
@@ -237,7 +245,9 @@ private void insertChangePoints(Iterable<ChangeType> changeTypes) {
 
             try {
                 // TODO: How to handle case when there are no change points
-                if (changeType != null && pageStartIndex <= changeType.changePoint() && changeType.changePoint() < pageStartIndex + inputPage.getPositionCount()) {
+                if (changeType != null
+                    && pageStartIndex <= changeType.changePoint()
+                    && changeType.changePoint() < pageStartIndex + inputPage.getPositionCount()) {
                     try (
                         BytesRefBlock.Builder changeTypeBlockBuilder = blockFactory.newBytesRefBlockBuilder(inputPage.getPositionCount());
                         DoubleBlock.Builder pvalueBlockBuilder = blockFactory.newDoubleBlockBuilder(inputPage.getPositionCount())
@@ -298,7 +308,10 @@ public String toString() {
     }
 
     private static String describe(int metricChannel, Optional<Integer> partitionChannel) {
-        return "ChangePointOperator[metricChannel=" + metricChannel + (partitionChannel.isPresent() ? ", partitionChannel=" + partitionChannel.get() : "") + "]";
+        return "ChangePointOperator[metricChannel="
+            + metricChannel
+            + (partitionChannel.isPresent() ? ", partitionChannel=" + partitionChannel.get() : "")
+            + "]";
     }
 
     private Warnings warnings(boolean onlyWarnings) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/topn/TopNOperator.java

@@ -441,78 +441,78 @@ private Iterator<Page> toPages() {
         // TODO: optimize case where all the queues are empty
         try {
             for (var entry : inputQueues.entrySet()) {
-            Queue inputQueue = entry.getValue();
+                Queue inputQueue = entry.getValue();
 
-            list = new ArrayList<>(inputQueue.size());
-            builders = null;
-            while (inputQueue.size() > 0) {
-                list.add(inputQueue.pop());
-            }
-            Collections.reverse(list);
-
-            int p = 0;
-            int size = 0;
-            for (int i = 0; i < list.size(); i++) {
-                if (builders == null) {
-                    size = Math.min(maxPageSize, list.size() - i);
-                    builders = new ResultBuilder[elementTypes.size()];
-                    for (int b = 0; b < builders.length; b++) {
-                        builders[b] = ResultBuilder.resultBuilderFor(
-                            blockFactory,
-                            elementTypes.get(b),
-                            encoders.get(b).toUnsortable(),
-                            channelInKey(sortOrders, b),
-                            size
-                        );
-                    }
-                    p = 0;
+                list = new ArrayList<>(inputQueue.size());
+                builders = null;
+                while (inputQueue.size() > 0) {
+                    list.add(inputQueue.pop());
                 }
+                Collections.reverse(list);
+
+                int p = 0;
+                int size = 0;
+                for (int i = 0; i < list.size(); i++) {
+                    if (builders == null) {
+                        size = Math.min(maxPageSize, list.size() - i);
+                        builders = new ResultBuilder[elementTypes.size()];
+                        for (int b = 0; b < builders.length; b++) {
+                            builders[b] = ResultBuilder.resultBuilderFor(
+                                blockFactory,
+                                elementTypes.get(b),
+                                encoders.get(b).toUnsortable(),
+                                channelInKey(sortOrders, b),
+                                size
+                            );
+                        }
+                        p = 0;
+                    }
 
-                Row row = list.get(i);
-                BytesRef keys = row.keys.bytesRefView();
-                for (SortOrder so : sortOrders) {
-                    if (keys.bytes[keys.offset] == so.nul()) {
+                    Row row = list.get(i);
+                    BytesRef keys = row.keys.bytesRefView();
+                    for (SortOrder so : sortOrders) {
+                        if (keys.bytes[keys.offset] == so.nul()) {
+                            keys.offset++;
+                            keys.length--;
+                            continue;
+                        }
                         keys.offset++;
                         keys.length--;
-                        continue;
+                        builders[so.channel].decodeKey(keys);
+                    }
+                    if (keys.length != 0) {
+                        throw new IllegalArgumentException("didn't read all keys");
                     }
-                    keys.offset++;
-                    keys.length--;
-                    builders[so.channel].decodeKey(keys);
-                }
-                if (keys.length != 0) {
-                    throw new IllegalArgumentException("didn't read all keys");
-                }
-
-                BytesRef values = row.values.bytesRefView();
-                for (ResultBuilder builder : builders) {
-                    builder.decodeValue(values);
-                }
-                if (values.length != 0) {
-                    throw new IllegalArgumentException("didn't read all values");
-                }
 
-                list.set(i, null);
-                row.close();
+                    BytesRef values = row.values.bytesRefView();
+                    for (ResultBuilder builder : builders) {
+                        builder.decodeValue(values);
+                    }
+                    if (values.length != 0) {
+                        throw new IllegalArgumentException("didn't read all values");
+                    }
 
-                p++;
-                if (p == size) {
-                    Block[] blocks = new Block[builders.length];
-                    try {
-                        for (int b = 0; b < blocks.length; b++) {
-                            blocks[b] = builders[b].build();
-                        }
-                    } finally {
-                        if (blocks[blocks.length - 1] == null) {
-                            Releasables.closeExpectNoException(blocks);
+                    list.set(i, null);
+                    row.close();
+
+                    p++;
+                    if (p == size) {
+                        Block[] blocks = new Block[builders.length];
+                        try {
+                            for (int b = 0; b < blocks.length; b++) {
+                                blocks[b] = builders[b].build();
+                            }
+                        } finally {
+                            if (blocks[blocks.length - 1] == null) {
+                                Releasables.closeExpectNoException(blocks);
+                            }
                         }
+                        result.add(new Page(blocks));
+                        Releasables.closeExpectNoException(builders);
+                        builders = null;
                     }
-                    result.add(new Page(blocks));
-                    Releasables.closeExpectNoException(builders);
-                    builders = null;
                 }
-            }
-            assert builders == null;
+                assert builders == null;
             }
             success = true;
             return result.iterator();

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ChangePointByOperatorTests.java

@@ -30,7 +30,7 @@ public class ChangePointByOperatorTests extends OperatorTestCase {
     @Override
     protected SourceOperator simpleInput(BlockFactory blockFactory, int size) {
         // size must be in [25, 1000] for ChangePoint to function correctly and detect the step change.
-        size = 25;//Math.clamp(size, 25, 1000);
+        size = 25;// Math.clamp(size, 25, 1000);
         List<Tuple<Long, BytesRef>> data = new ArrayList<>(size);
         for (int i = 0; i < size; i++) {  // step change 0 -> 100
             data.add(Tuple.tuple(i < size / 2 ? randomLongBetween(0, 3) : randomLongBetween(100, 103), new BytesRef("prod")));
@@ -81,7 +81,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> output) {
 
     @Override
     protected Operator.OperatorFactory simple() {
-        return new ChangePointOperator.Factory(0, Optional.of(1), null,0, 0);
+        return new ChangePointOperator.Factory(0, Optional.of(1), null, 0, 0);
     }
 
     @Override

x-pack/plugin/esql/compute/test/src/main/java/org/elasticsearch/compute/test/AbstractBlockSourceOperator.java

@@ -10,7 +10,6 @@
 import org.elasticsearch.compute.data.BlockFactory;
 import org.elasticsearch.compute.data.Page;
 import org.elasticsearch.compute.operator.SourceOperator;
-import org.elasticsearch.test.ESTestCase;
 
 /**
  * An abstract source operator. Implementations of this operator produce pages with a random

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/ChangePoint.java

@@ -51,7 +51,15 @@ public class ChangePoint extends UnaryPlan implements SurrogateLogicalPlan, Post
 
     private List<Attribute> output;
 
-    public ChangePoint(Source source, LogicalPlan child, Attribute value, Attribute key, Attribute partitionField, Attribute targetType, Attribute targetPvalue) {
+    public ChangePoint(
+        Source source,
+        LogicalPlan child,
+        Attribute value,
+        Attribute key,
+        Attribute partitionField,
+        Attribute targetType,
+        Attribute targetPvalue
+    ) {
         super(source, child);
         this.value = value;
         this.key = key;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/TopN.java

@@ -11,7 +11,6 @@
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.xpack.esql.core.capabilities.Resolvables;
-import org.elasticsearch.xpack.esql.core.expression.Attribute;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.NodeInfo;
 import org.elasticsearch.xpack.esql.core.tree.Source;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/TopNExec.java

@@ -39,7 +39,14 @@ public class TopNExec extends UnaryExec implements EstimatesRowSize {
      */
     private final Integer estimatedRowSize;
 
-    public TopNExec(Source source, PhysicalPlan child, Expression partitionField, List<Order> order, Expression limit, Integer estimatedRowSize) {
+    public TopNExec(
+        Source source,
+        PhysicalPlan child,
+        Expression partitionField,
+        List<Order> order,
+        Expression limit,
+        Integer estimatedRowSize
+    ) {
         super(source, child);
         this.partitionField = partitionField;
         this.order = order;
@@ -106,7 +113,8 @@ public Integer estimatedRowSize() {
     @Override
     public PhysicalPlan estimateRowSize(State state) {
         final List<Attribute> output = output();
-        final boolean needsSortedDocIds = output.stream().anyMatch(a -> a.typeResolved().resolved() && a.dataType() == DataType.DOC_DATA_TYPE);
+        final boolean needsSortedDocIds = output.stream()
+            .anyMatch(a -> a.typeResolved().resolved() && a.dataType() == DataType.DOC_DATA_TYPE);
         state.add(needsSortedDocIds, output);
         int size = state.consumeAllFields(true);
         size = Math.max(size, 1);

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/LocalExecutionPlanner.java

@@ -762,7 +762,7 @@ private PhysicalOperation planProject(ProjectExec project, LocalExecutionPlanner
             Layout.ChannelAndType input = source.layout.get(inputId);
             if (input == null) {
                 continue;
-//                throw new IllegalStateException("can't find input for [" + ne + "]");  // TODO: uncomment?
+                // throw new IllegalStateException("can't find input for [" + ne + "]"); // TODO: uncomment?
             }
             layout.append(ne);
             projectionList.add(input.channel());
@@ -821,7 +821,9 @@ private PhysicalOperation planChangePoint(ChangePointExec changePoint, LocalExec
         return source.with(
             new ChangePointOperator.Factory(
                 layout.get(changePoint.value().id()).channel(),
-                changePoint.partitionField() != null ? Optional.of(layout.get(changePoint.partitionField().id()).channel()) : Optional.empty(),
+                changePoint.partitionField() != null
+                    ? Optional.of(layout.get(changePoint.partitionField().id()).channel())
+                    : Optional.empty(),
                 changePoint.sourceText(),
                 changePoint.sourceLocation().getLineNumber(),
                 changePoint.sourceLocation().getColumnNumber()

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/logical/TopNSerializationTests.java

@@ -46,7 +46,10 @@ protected TopN mutateInstance(TopN instance) throws IOException {
         Expression limit = instance.limit();
         switch (between(0, 3)) {
             case 0 -> child = randomValueOtherThan(child, () -> randomChild(0));
-            case 1 -> partitionField = randomValueOtherThan(partitionField, () -> new Literal(randomSource(), randomAlphaOfLengthBetween(1, 10), DataType.KEYWORD));
+            case 1 -> partitionField = randomValueOtherThan(
+                partitionField,
+                () -> new Literal(randomSource(), randomAlphaOfLengthBetween(1, 10), DataType.KEYWORD)
+            );
             case 2 -> order = randomValueOtherThan(order, TopNSerializationTests::randomOrders);
             case 3 -> limit = randomValueOtherThan(limit, AbstractExpressionSerializationTests::randomChild);
         }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/physical/TopNExecSerializationTests.java

@@ -48,7 +48,10 @@ protected TopNExec mutateInstance(TopNExec instance) throws IOException {
                 estimatedRowSize,
                 AbstractPhysicalPlanSerializationTests::randomEstimatedRowSize
             );
-            case 4 -> partitionField = randomValueOtherThan(partitionField, () -> new Literal(randomSource(), randomAlphaOfLengthBetween(1, 10), DataType.KEYWORD));
+            case 4 -> partitionField = randomValueOtherThan(
+                partitionField,
+                () -> new Literal(randomSource(), randomAlphaOfLengthBetween(1, 10), DataType.KEYWORD)
+            );
             default -> throw new UnsupportedOperationException();
         }
         return new TopNExec(instance.source(), child, partitionField, order, limit, estimatedRowSize);