Use forRecord a few times to serve as examples

Author: prdoyle

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/direct/DatabaseConfiguration.java

@@ -259,10 +259,10 @@ public String getWriteableName() {
 
         private static final ParseField ACCOUNT_ID = new ParseField("account_id");
 
-        private static final ConstructingObjectParser<Maxmind, Void> PARSER = new ConstructingObjectParser<>("maxmind", false, (a, id) -> {
-            String accountId = (String) a[0];
-            return new Maxmind(accountId);
-        });
+        private static final ConstructingObjectParser<Maxmind, Void> PARSER = ConstructingObjectParser.forRecord(
+            "maxmind",
+            false,
+            Maxmind.class);
 
         static {
             PARSER.declareString(ConstructingObjectParser.constructorArg(), ACCOUNT_ID);

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamAutoShardingEvent.java

@@ -36,10 +36,10 @@ public record DataStreamAutoShardingEvent(String triggerIndexName, int targetNum
     public static final ParseField EVENT_TIME = new ParseField("event_time");
     public static final ParseField EVENT_TIME_MILLIS = new ParseField("event_time_millis");
 
-    public static final ConstructingObjectParser<DataStreamAutoShardingEvent, Void> PARSER = new ConstructingObjectParser<>(
+    public static final ConstructingObjectParser<DataStreamAutoShardingEvent, Void> PARSER = ConstructingObjectParser.forRecord(
         "auto_sharding",
         false,
-        (args, unused) -> new DataStreamAutoShardingEvent((String) args[0], (int) args[1], (long) args[2])
+        DataStreamAutoShardingEvent.class
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamFailureStore.java

@@ -44,10 +44,10 @@ public record DataStreamFailureStore(@Nullable Boolean enabled, @Nullable DataSt
     public static final ParseField ENABLED_FIELD = new ParseField(ENABLED);
     public static final ParseField LIFECYCLE_FIELD = new ParseField(LIFECYCLE);
 
-    public static final ConstructingObjectParser<DataStreamFailureStore, Void> PARSER = new ConstructingObjectParser<>(
+    public static final ConstructingObjectParser<DataStreamFailureStore, Void> PARSER = ConstructingObjectParser.forRecord(
         FAILURE_STORE,
         false,
-        (args, unused) -> new DataStreamFailureStore((Boolean) args[0], (DataStreamLifecycle) args[1])
+        DataStreamFailureStore.class
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamOptions.java

@@ -42,10 +42,10 @@ public record DataStreamOptions(@Nullable DataStreamFailureStore failureStore)
     public static final DataStreamOptions FAILURE_STORE_DISABLED = new DataStreamOptions(new DataStreamFailureStore(false, null));
     public static final DataStreamOptions EMPTY = new DataStreamOptions(null);
 
-    public static final ConstructingObjectParser<DataStreamOptions, Void> PARSER = new ConstructingObjectParser<>(
+    public static final ConstructingObjectParser<DataStreamOptions, Void> PARSER = ConstructingObjectParser.forRecord(
         "options",
         false,
-        (args, unused) -> new DataStreamOptions((DataStreamFailureStore) args[0])
+        DataStreamOptions.class
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadataStats.java

@@ -131,11 +131,10 @@ public record AverageShardSize(long totalSizeInBytes, int numberOfShards) implem
         public static final ParseField TOTAL_SIZE_IN_BYTES_FIELD = new ParseField("total_size_in_bytes");
         public static final ParseField SHARD_COUNT_FIELD = new ParseField("shard_count");
 
-        @SuppressWarnings("unchecked")
-        private static final ConstructingObjectParser<AverageShardSize, Void> PARSER = new ConstructingObjectParser<>(
+        private static final ConstructingObjectParser<AverageShardSize, Void> PARSER = ConstructingObjectParser.forRecord(
             "average_shard_size",
             false,
-            (args, unused) -> new AverageShardSize((long) args[0], (int) args[1])
+            AverageShardSize.class
         );
 
         static {

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/profile/ProfileDocument.java

@@ -126,16 +126,10 @@ public static ProfileDocument fromXContent(XContentParser parser) {
     }
 
     @SuppressWarnings("unchecked")
-    static final ConstructingObjectParser<ProfileDocumentUser, Void> PROFILE_DOC_USER_PARSER = new ConstructingObjectParser<>(
+    static final ConstructingObjectParser<ProfileDocumentUser, Void> PROFILE_DOC_USER_PARSER = ConstructingObjectParser.forRecord(
         "user_profile_document_user",
         false,
-        (args, v) -> new ProfileDocumentUser(
-            (String) args[0],
-            (List<String>) args[1],
-            (Authentication.RealmRef) args[2],
-            (String) args[3],
-            (String) args[4]
-        )
+        ProfileDocumentUser.class
     );
 
     @SuppressWarnings("unchecked")