Merge branch 'structured_source_benchmark' into structured_source

Author: Tim-Brooks

server/src/main/java/org/elasticsearch/common/io/stream/RecyclerBytesStreamOutput.java

@@ -114,7 +114,7 @@ private void writeAdditionalPages(byte[] b, int offset, int length) {
     public void writeUTF8String(String str) throws IOException {
         final int charCount = str.length();
         if (charCount == 0) {
-            writeVInt(0);
+            writeByte((byte) 0);
             return;
         }
 
@@ -138,10 +138,6 @@ public void writeUTF8String(String str) throws IOException {
         }
     }
 
-    /**
-     * Fast path for writing ASCII characters. Returns true if all characters
-     * were ASCII, false if a non-ASCII character was encountered.
-     */
     private boolean writeAsciiChars(String str, int charCount) {
         int charIndex = 0;
 
@@ -157,7 +153,6 @@ private boolean writeAsciiChars(String str, int charCount) {
                 bytesRefBytes[bytesRefOffset + currentPageOffset + i] = (byte) c;
             }
 
-            // Update positions for what we wrote
             currentPageOffset += charsToWrite;
             charIndex += charsToWrite;
 
@@ -166,7 +161,7 @@ private boolean writeAsciiChars(String str, int charCount) {
             }
         }
 
-        return true; // All characters were ASCII
+        return true;
     }
 
     private void handleNonAsciiString(String str) throws IOException {