Remove unneeded source to map method

The source to map method which takes a decorator as an argument is
always called with the NOOP variant. This is the default variant used
when the method which does not take a parameter is called. Remove the
needed method.

Author: Tim-Brooks

server/src/main/java/org/elasticsearch/action/index/IndexRequest.java

@@ -39,7 +39,6 @@
 import org.elasticsearch.index.mapper.MapperService;
 import org.elasticsearch.index.shard.ShardId;
 import org.elasticsearch.ingest.IngestService;
-import org.elasticsearch.plugins.internal.XContentParserDecorator;
 import org.elasticsearch.xcontent.XContentBuilder;
 import org.elasticsearch.xcontent.XContentFactory;
 import org.elasticsearch.xcontent.XContentType;
@@ -419,10 +418,6 @@ public Map<String, Object> sourceAsMap() {
         return XContentHelper.convertToMap(source, false, contentType).v2();
     }
 
-    public Map<String, Object> sourceAsMap(XContentParserDecorator parserDecorator) {
-        return XContentHelper.convertToMap(source, false, contentType, parserDecorator).v2();
-    }
-
     /**
      * Index the Map in {@link Requests#INDEX_CONTENT_TYPE} format
      *

server/src/main/java/org/elasticsearch/action/update/UpdateHelper.java

@@ -193,11 +193,7 @@ Result prepareUpdateIndexRequest(IndexShard indexShard, UpdateRequest request, G
         final XContentType updateSourceContentType = sourceAndContent.v1();
         final Map<String, Object> updatedSourceAsMap = sourceAndContent.v2();
 
-        final boolean noop = XContentHelper.update(
-            updatedSourceAsMap,
-            currentRequest.sourceAsMap(XContentParserDecorator.NOOP),
-            detectNoop
-        ) == false;
+        final boolean noop = XContentHelper.update(updatedSourceAsMap, currentRequest.sourceAsMap(), detectNoop) == false;
 
         // We can only actually turn the update into a noop if detectNoop is true to preserve backwards compatibility and to handle cases
         // where users repopulating multi-fields or adding synonyms, etc.

server/src/main/java/org/elasticsearch/ingest/IngestService.java

@@ -1345,7 +1345,7 @@ private static IngestDocument newIngestDocument(final IndexRequest request) {
             request.version(),
             request.routing(),
             request.versionType(),
-            request.sourceAsMap(XContentParserDecorator.NOOP)
+            request.sourceAsMap()
         );
     }