-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Closed
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsMetaTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)
Description
I'd like to make sure that every function has:
- Unit tests containing
- Comprehensive type coverage
- Null inputs, usually generated by
anyNullIsNull
- Type error inputs, usually generated by
errorsForCasesWithoutExamples
A documentation page containingCovered by the checklist in [ES|QL] Automate part of doc generation via annotations #104247 (comment)- In
SHOW FUNCTIONS
- A description
- Parameter names
- Parameter types
Here's a list of all the functions. At the time of first writing some of these have some of these things, but few have all of them.
-
%
(Mark) -
*
(Mark) -
+
(Mark)- full null testing is blocked on the date math nulls issue([ES|QL] Null handling in date math #103085)
- ESQL: Arithmetic between unsigned long and long leads to null values due to implicit casting #102935 is a blocker for type checking in binary arithmetic operations
-
-
(Mark) -
/
(Mark) -
==
-
!=
-
>
-
>=
-
<
-
<=
-
Abs
-
Acos
[ESQL] Inverse trig function argument descriptions #105525 -
Asin
[ESQL] Inverse trig function argument descriptions #105525 -
Atan
[ESQL] Inverse trig function argument descriptions #105525 -
Atan2
[ESQL] Inverse trig function argument descriptions #105525 -
AutoBucket
-
Case
-
Ceil
-
CIDRMatch
-
Coalesce
-
Concat
-
Cos
[ES|QL] Trig & hyperbolic function finishing pass #103205 -
Cosh
[ES|QL] Trig & hyperbolic function finishing pass #103205 -
DateExtract
-
DateFormat
-
DateParse
-
DateTrunc
-
E
-
EndsWith
-
Floor
-
Greatest
-
IsFinite
[ESQL] Remove is_nan, is_finite, and is_infinite #104091 -
IsInfinite
[ESQL] Remove is_nan, is_finite, and is_infinite #104091 -
IsNaN
[ESQL] Remove is_nan, is_finite, and is_infinite #104091 -
Least
-
Left
-
Length
-
Log
ESQL: Fixup docs for LOG and LOG10 #106963 -
Log10
ESQL: Fixup docs for LOG and LOG10 #106963 -
LTrim
ESQL: Extra tests for trim/ltrim/rtrim #102308 -
MvAvg
-
MvConcat
ESQL: More MV_* tests #100564 -
MvCount
ESQL: More MV_* tests #100564 -
MvDedupe
ESQL: More MV_* tests #100564 -
MvMax
ESQL: More MV_* tests #100564 -
MvMedian
-
MvMin
ESQL: More MV_* tests #100564 -
MvSum
-
Neg
-
Now
-
Pow
[ES|QL] pow function always returns double #102183 -
Pi
-
Replace
-
Right
-
Round
-
RTrim
ESQL: Extra tests for trim/ltrim/rtrim #102308 -
Sin
-
Sinh
[ES|QL] Trig & hyperbolic function finishing pass #103205 -
Split
-
Sqrt
-
StartsWith
-
Substring
-
Tan
[ES|QL] Trig & hyperbolic function finishing pass #103205 -
Tanh
[ES|QL] Trig & hyperbolic function finishing pass #103205 -
Tau
-
ToBoolean
-
ToCartesianPoint
Addto_XXXpoint()
unit tests. Fix exception clause #103507 -
ToDatetime
-
ToDegrees
-
ToDegrees
-
ToDouble
-
ToGeoPoint
Addto_XXXpoint()
unit tests. Fix exception clause #103507 -
ToInteger
-
ToIP
-
ToLong
-
ToRadians
-
ToRadians
-
ToString
-
ToString
-
ToUnsignedLong
-
ToVersion
-
Trim
ESQL: Extra tests for trim/ltrim/rtrim #102308
After we've done this we can:
- Remove
AbstractScalarFunctionTestCase
- all this class does is provide a weaker version of theanyNullIsNull
assertions.
stratoula
Metadata
Metadata
Assignees
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsMetaTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)