Skip to content

Add AggregateMetricDouble/Block to misc. tests in ES|QL #131951

@limotova

Description

@limotova

AggregateMetricDouble and its Block is missing from a few tests

Still missing:
In org.elasticsearch.compute.data:

  • BlockAccountingTests
  • CompositeBlockTests (requires multi-value support)
  • BasicBlockTests (some; requires Vector support)

#132355 Covers the following:

In org.elasticsearch.compute.data:

  • AggregateMetricDoubleBlockEqualityTests (previously only null equality was tested)
  • BasicBlockTests
  • BasicPageTests
  • BlockBuilderCopyFromTests
  • BlockBuilderTests
  • BlockFactoryTests
  • BlockSerializationTests
  • BlockValueAsserter
  • FilteredBlockTests

org.elasticsearch.compute.operator.topn:

  • TopNEncoderTests (We don't directly encode aggregate_metric_double so this does not apply actually)

org.elasticsearch.compute.test:

  • BlockTestUtils (add to randomValue and append and see where it takes us)
  • RandomBlock (add to randomBlock and randomElementType and see where it takes us)

org.elasticsearch.xpack.esql.analysis:

  • AnalyzerTests (test implicit casting of aggregate metric double)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions