- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Open
Labels
:StorageEngine/TSDBYou know, for MetricsYou know, for Metrics>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:StorageEngine
Description
AggregateMetricDouble and its Block is missing from a few tests
Still missing:
In org.elasticsearch.compute.data:
- BlockAccountingTests
 - CompositeBlockTests (requires multi-value support)
 - BasicBlockTests (some; requires Vector support)
 
#132355 Covers the following:
In org.elasticsearch.compute.data:
- AggregateMetricDoubleBlockEqualityTests (previously only null equality was tested)
 - BasicBlockTests
 - BasicPageTests
 - BlockBuilderCopyFromTests
 - BlockBuilderTests
 - BlockFactoryTests
 - BlockSerializationTests
 - BlockValueAsserter
 - FilteredBlockTests
 
org.elasticsearch.compute.operator.topn:
TopNEncoderTests(We don't directly encode aggregate_metric_double so this does not apply actually)
org.elasticsearch.compute.test:
- BlockTestUtils (add to randomValue and append and see where it takes us)
 - RandomBlock (add to randomBlock and randomElementType and see where it takes us)
 
org.elasticsearch.xpack.esql.analysis:
- AnalyzerTests (test implicit casting of aggregate metric double)
 
Metadata
Metadata
Assignees
Labels
:StorageEngine/TSDBYou know, for MetricsYou know, for Metrics>testIssues or PRs that are addressing/adding testsIssues or PRs that are addressing/adding testsTeam:StorageEngine