-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Open
Labels
:Search Foundations/SearchCatch all for Search FoundationsCatch all for Search Foundations:Search/SearchSearch-related issues that do not fall into other categoriesSearch-related issues that do not fall into other categories>bugTeam:SearchMeta label for search teamMeta label for search teamTeam:Search FoundationsMeta label for the Search Foundations team in ElasticsearchMeta label for the Search Foundations team in Elasticsearchpriority:highA label for assessing bug priority to be used by ES engineersA label for assessing bug priority to be used by ES engineers
Description
While adding additional assertCurrentThreadPool in ES|QL code we noticed that after executing
Lines 50 to 54 in 8486a63
| Rewriteable.rewriteAndFetch( | |
| new FunctionsRewriteable(plan), | |
| queryRewriteContext(services, indexNames(plan)), | |
| listener.delegateFailureAndWrap((l, r) -> l.onResponse(r.plan)) | |
| ); |
from the SEARCH threadpool, a listener (and everything happening after) it could end up on a wide variety of threads including
transport, seeelasticsearch/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
Lines 201 to 207 in e0296d0
| assert ThreadPool.assertCurrentThreadPool( | |
| TcpTransport.TRANSPORT_WORKER_THREAD_NAME_PREFIX, | |
| ThreadPool.Names.SYSTEM_READ, | |
| ThreadPool.Names.SEARCH, | |
| ThreadPool.Names.SEARCH_COORDINATION, | |
| MachineLearning.NATIVE_INFERENCE_COMMS_THREAD_POOL_NAME | |
| ); |
I believe it is not expected. If it is, it would be ideal to document it so that users of this api are aware and fork back to the correct thread pool.
Metadata
Metadata
Assignees
Labels
:Search Foundations/SearchCatch all for Search FoundationsCatch all for Search Foundations:Search/SearchSearch-related issues that do not fall into other categoriesSearch-related issues that do not fall into other categories>bugTeam:SearchMeta label for search teamMeta label for search teamTeam:Search FoundationsMeta label for the Search Foundations team in ElasticsearchMeta label for the Search Foundations team in Elasticsearchpriority:highA label for assessing bug priority to be used by ES engineersA label for assessing bug priority to be used by ES engineers