-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Open
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>bugTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)
Description
As a follow up to #134910, we need to be more robust in the way we handle possibly null exception messages.
JDK 25 added optimizations that might cause the error message to be removed in some Math.exact*
calls. See https://bugs.openjdk.org/browse/JDK-8367990.
Example of relevant (generated) code:
Simplest solution I can think of is to a add a new kind of annotation with an extra error message on null, so the generated code would recreate the exception on null (possibly only when actually creating the exception in https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Warnings.java#L116).
quackaplop
Metadata
Metadata
Assignees
Labels
:Analytics/ES|QLAKA ESQLAKA ESQL>bugTeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)Meta label for analytical engine team (ESQL/Aggs/Geo)