Add name to role mappings in cluster state #114506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prerequisite to #114305.
This will write the
ExpressionRoleMapping::namefield as part of theRoleMappingMetadatapersisted in cluster state. The idea is that this PR will be merged after the PR that ensures thatsettings.jsonis reloaded on every restart. Whensettings.jsonis loaded, theRoleMappingMetadatawill be rewritten to cluster state with each mapping containing the new name field.RoleMappingMetadatawill be written to cluster state and persisted for all contexts, that meansSNAPSHOT,GATEWAYandAPI.GATEWAY- This is persisted across master node restarts, so I've added a new node feature to make sure that all nodes have the new parser before writing.SNAPSHOT- This is persisted for snapshot purposes. Since you can’t restore an index to an earlier version of Elasticsearch persisting the new field if all nodes have the parser, should guarantee that it can be parsed after restore.API- This is persisted in the cluster state API. No additional work is needed to support this.