Skip to content

Conversation

ImadSaddik
Copy link
Contributor

In the documentation's description section, there is a link or reference to the "request body" within a paragraph. However, when users click on this link, it fails to redirect them to the intended "request body" section of the document.

I was just reading the search API and I found this issue, it should be a quick fix.

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 needs:triage Requires assignment of a team area label labels Oct 18, 2024
@ImadSaddik
Copy link
Contributor Author

Here is the new PR @leemthompo

@leemthompo leemthompo self-assigned this Oct 21, 2024
@leemthompo leemthompo added Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v8.15.0 v8.16.0 labels Oct 21, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Docs Meta label for docs team label Oct 21, 2024
@leemthompo
Copy link
Contributor

@elasticmachine test this

@leemthompo
Copy link
Contributor

run docs-build

@leemthompo leemthompo added the >docs General docs changes label Oct 21, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Oct 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing @ImadSaddik! LGTM.

@ImadSaddik
Copy link
Contributor Author

You are welcome @leemthompo

@leemthompo leemthompo merged commit eae3a42 into elastic:main Oct 21, 2024
8 of 9 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 115156

@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.15

Questions ?

Please refer to the Backport tool documentation

@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Oct 21, 2024
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Oct 21, 2024
elasticsearchmachine pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit eae3a42)

Co-authored-by: Imad Saddik <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit eae3a42)

Co-authored-by: Imad Saddik <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit eae3a42)

Co-authored-by: Imad Saddik <[email protected]>
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.0 v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants