Set assignment state to "started" in case of zero allocations #115824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
jan-elastic
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jan-elastic
commented
Oct 29, 2024
| return assignmentState; | ||
| } | ||
| if (taskParams.getNumberOfAllocations() == 0) { | ||
| return AssignmentState.STARTED; |
There was a problem hiding this comment.
There are code paths where you can get into state of numberOfAllocations=0 and assignmentState=STARTING. I think that can happen when the scheduler moves jobs around, which triggers the state to be recalculated here.
This causes issues, because assignments in a STARTING state cannot be updated, and an assignment with numberOfAllocations=0 won't get out of that state.
prwhelan
approved these changes
Oct 29, 2024
jan-elastic
added
the
auto-backport
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
jan-elastic
added a commit
that referenced
this pull request
Oct 29, 2024
jan-elastic
added a commit
that referenced
this pull request
Oct 29, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Oct 29, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.