Skip to content

Conversation

Ekwinder
Copy link
Contributor

@Ekwinder Ekwinder commented Nov 3, 2024

Update new_field to language which is the actual new field added in dynamic mapping

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Update `new_field` to `language` which is the actual new field added in dynamic mapping
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.15.5 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 3, 2024
@gbanasiak gbanasiak added the >docs General docs changes label Nov 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Nov 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@gbanasiak
Copy link
Contributor

The fix is incomplete, example needs to be aligned as well.

@leemthompo
Copy link
Contributor

@Ekwinder thanks for catching this! Would you like to update the example too? I can take this over the finish line if you'd like. :)

@Ekwinder
Copy link
Contributor Author

@leemthompo Sorry, I missed the notifications somehow, yeah I have updated the example as well!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs @Ekwinder!

@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 v8.18.0 v9.0.0 labels Jan 29, 2025
@leemthompo
Copy link
Contributor

run docs-build

@leemthompo
Copy link
Contributor

@elasticmachine test this

@leemthompo leemthompo merged commit f73545b into elastic:8.15 Jan 29, 2025
7 checks passed
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.16
main
8.17
8.x

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping
elasticsearchmachine pushed a commit that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping

Co-authored-by: Ekwinder <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping

Co-authored-by: Ekwinder <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping

Co-authored-by: Ekwinder <[email protected]>
leemthompo added a commit that referenced this pull request Jan 29, 2025
Update `new_field` to `language` which is the actual new field added in dynamic mapping

Co-authored-by: Ekwinder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.6 v8.16.0 v8.17.0 v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants