Skip to content

Conversation

leemthompo
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

* Add initial query rules retriever docs

* Add docs tests

* Apply suggestions from code review

Co-authored-by: Liam Thompson <[email protected]>

* PR feedback

* Make query rules guide retriever-first

* Add warning to DSL doc

* Update docs/reference/search/retriever.asciidoc

Co-authored-by: Mike Pellegrini <[email protected]>

* Update docs/reference/search/retriever.asciidoc

Co-authored-by: Mike Pellegrini <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mike Pellegrini <[email protected]>

* Give parameters subheading an explicit id

* Fix formatting

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Mike Pellegrini <[email protected]>
(cherry picked from commit 14a7b8f)
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Documentation preview:

@leemthompo leemthompo added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 7, 2024
@leemthompo leemthompo requested a review from kderusso November 7, 2024 14:07
@leemthompo
Copy link
Contributor Author

even the the auto-merge-without-approval label didn't work this time 😭

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leemthompo leemthompo merged commit b24151a into elastic:8.x Nov 7, 2024
6 checks passed
@leemthompo leemthompo deleted the backport/8.x/pr-115696 branch November 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants