Speedup IndexNameExpressionResolver some more #117207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need a list here, since we're not escaping it might as well use an array outright and get faster iteration. Also, the hot lookup on the FeatureFlag won't compile away. There's no point in the indirection functionally, might as well use the boolean outright and compile better with a trusted constant.
original-brownbear
added
>non-issue
:Data Management/Indices APIs
elasticsearchmachine
added
v9.0.0
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine update branch |
nielsbauman
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM, but I'm requesting a review from @jbaiera to double-check the feature flag changes as he's been in contact with Core Infra a few times about them.
Thanks @original-brownbear!
|
Sorry for the late response on this - These changes look alright to me, though we've had a pretty sizable refactoring done to the index name expression resolver since this was opened. I'm +1 to the simplifying of the feature flag. I imagine the other parts of this PR may need a small update. |
|
Closing because the feature flag is now gone and the other code refactorings are not applicable anymore after previous refactorings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a list here, since we're not escaping it might as well use an array outright and get faster iteration.
Also, the hot lookup on the FeatureFlag won't compile away. There's no point in the indirection functionally, might as well use the boolean outright and compile better with a trusted constant.