Remove old InvalidateApiKeyRequest transport versions #118290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>refactoring
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
thecoop
commented
Dec 9, 2024
| ByteArrayOutputStream bos = new ByteArrayOutputStream(); | ||
| OutputStreamStreamOutput osso = new OutputStreamStreamOutput(bos) | ||
| ) { | ||
| TransportVersion streamVersion = randomVersionBetween( |
There was a problem hiding this comment.
This version doesn't seem to affect the test behaviour?
There was a problem hiding this comment.
Yeah, I can't work out why this was added. I assume it was an artifact from an earlier incomplete implementation that got retained unnecessarily.
thecoop
force-pushed
the
remove-old-invalidateapikeyrequest-transports
branch
from
ef9846d to
f31884a
Compare
thecoop
added
auto-backport
tvernum
approved these changes
Mar 19, 2025
| ByteArrayOutputStream bos = new ByteArrayOutputStream(); | ||
| OutputStreamStreamOutput osso = new OutputStreamStreamOutput(bos) | ||
| ) { | ||
| TransportVersion streamVersion = randomVersionBetween( |
There was a problem hiding this comment.
Yeah, I can't work out why this was added. I assume it was an artifact from an earlier incomplete implementation that got retained unnecessarily.
💚 Backport successful
|
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Mar 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 7.3 and 7.10 transport changes to
InvalidateApiKeyRequest