Delete accidentally added file, and gitignore #118971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
seanstory
added
Team:Search - Extract & Transform
and removed
needs:triage
elasticsearchmachine
added
needs:triage
joegallo
added
:Delivery/Tooling
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
joegallo
approved these changes
Dec 18, 2024
Contributor
joegallo
left a comment
joegallo
left a comment
There was a problem hiding this comment.
I 100% agree with the part about removing the accidentally committed file.
I 60% agree with the part about adding the file to .gitignore -- 40% me of thinks that's what .git/info/exclude is for, and 60% of me thinks enough people on the team use jenv that it's reasonable to promote the change from a per-developer ignored file into a project-wide ignored file.
If somebody in the future disagrees strongly with this being added, we can always remove it.
🚀
And thank you for fixing this, Sean!
seanstory
deleted the
seanstory/remove-mistakenly-committed-java-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally added here: https://github.com/elastic/elasticsearch/pull/118899/files#r1890345063