Skip to content

Adjustments to match Opster, readability #119812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 13, 2025
Merged

Adjustments to match Opster, readability #119812

merged 6 commits into from
Jan 13, 2025
+8 −5

Conversation

thekofimensah
Copy link
Contributor

Part of the logic of rearranging the order of the different clauses is that must_not + filter and must + should are more related and it makes sense in my opinion to order them by most similar, but this may be up to debate.

Also thought that this page was a bit general and I wanted to make it more explicit about which clauses are used for what and why.

This is part of the effort to bring in opster documentation to elastic.
https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Jan 9, 2025 •
edited
Loading

💚 CLA has been signed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.17.2 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 9, 2025
@shainaraskas shainaraskas added >docs General docs changes v9.0.0 v8.18.0 labels Jan 9, 2025
@shainaraskas shainaraskas self-requested a review January 9, 2025 13:35
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jan 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 9, 2025
@shainaraskas shainaraskas added the needs:triage Requires assignment of a team area label label Jan 9, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 9, 2025
@shainaraskas shainaraskas self-assigned this Jan 9, 2025
@shainaraskas
Copy link
Contributor

@elasticmachine test this please

@shainaraskas shainaraskas requested review from georgewallace and removed request for shainaraskas January 9, 2025 21:39
@shainaraskas shainaraskas removed their assignment Jan 9, 2025
@shainaraskas
Copy link
Contributor

run docs-build

georgewallace
georgewallace approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple suggestions to the content.

thekofimensah and others added 3 commits January 9, 2025 17:46
@thekofimensah @georgewallace
Edits
92f41ba 
Co-authored-by: George Wallace <[email protected]>
@thekofimensah @georgewallace
Spacing
a0c21a4 
Co-authored-by: George Wallace <[email protected]>
@thekofimensah
Merge branch '8.17' into patch-2
ed5bda9
@thekofimensah
Copy link
Contributor Author

run docs-build

@leemthompo leemthompo added the auto-backport Automatically create backport pull requests when merged label Jan 10, 2025
@leemthompo
Copy link
Contributor

leemthompo commented Jan 10, 2025 •
edited
Loading

@thekofimensah (for future reference) we recommend opening PRs against main branch, which makes it easier to reason about backports to other versions, and the backport PRs will automerge once they pass CI :)

@georgewallace georgewallace enabled auto-merge (squash) January 10, 2025 14:57
@leemthompo
Copy link
Contributor

leemthompo commented Jan 10, 2025 •
edited
Loading

FYI updating branch is rarely a requirement, unless you have conflicts, or wanna retrigger CI due to failures (e.g. broken links that merging upstream will fix)

@thekofimensah
Copy link
Contributor Author

FYI updating branch is rarely a requirement, unless you have conflicts, or wanna retrigger CI due to failures (e.g. broken links that merging upstream will fix)

Yeah I'm not sure why I can't merge it in the current state, good to know that updating the branch wouldn't do much.

@leemthompo
Copy link
Contributor

@elasticsearchmachine test this

@leemthompo
Copy link
Contributor

run docs-build

@leemthompo
Copy link
Contributor

@thekofimensah as external contributor we have to trigger CI manually every time.

I recommend, as much as possible, building docs locally :). Get started by cloning the elastic/docs repo.

@georgewallace georgewallace merged commit 6c28b7f into elastic:8.17 Jan 13, 2025
6 of 7 checks passed
This was referenced Jan 13, 2025
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ main
✅ 8.x

georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Jan 13, 2025
@thekofimensah @georgewallace
Adjustments to match Opster, readability (elastic#119812)
7929cf1 
* Adjustments to match Opster, readability

https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

* Edits

Co-authored-by: George Wallace <[email protected]>

* Spacing

Co-authored-by: George Wallace <[email protected]>

---------

Co-authored-by: George Wallace <[email protected]>
georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Jan 13, 2025
@thekofimensah @georgewallace
Adjustments to match Opster, readability (elastic#119812)
8b13cc2 
* Adjustments to match Opster, readability

https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

* Edits

Co-authored-by: George Wallace <[email protected]>

* Spacing

Co-authored-by: George Wallace <[email protected]>

---------

Co-authored-by: George Wallace <[email protected]>
@leemthompo
Copy link
Contributor

leemthompo commented Jan 13, 2025 •
edited
Loading

@georgewallace I just noticed that this auto-merged before docs build check passed which is a weird and bad side effect of the external contributor dynamics

elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2025
@georgewallace @thekofimensah
Adjustments to match Opster, readability (#119812) (#120032)
0c432ae 
* Adjustments to match Opster, readability

https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

* Edits



* Spacing



---------

Co-authored-by: Kofi B <[email protected]>
leemthompo pushed a commit that referenced this pull request Jan 13, 2025
@georgewallace @thekofimensah
Adjustments to match Opster, readability (#119812) (#120031)
8ac3c2d 
* Adjustments to match Opster, readability

https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

* Edits



* Spacing



---------

Co-authored-by: Kofi B <[email protected]>
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
@georgewallace @thekofimensah @martijnvg
Adjustments to match Opster, readability (elastic#119812) (elastic#12…
0e06c7b 
…0031)

* Adjustments to match Opster, readability

https://opster.com/guides/elasticsearch/search-apis/elasticsearch-bool-queries/

* Edits



* Spacing



---------

Co-authored-by: Kofi B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgewallace georgewallace georgewallace approved these changes

Assignees

@georgewallace georgewallace

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.17.2 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thekofimensah @elasticsearchmachine @shainaraskas @leemthompo @georgewallace