Skip to content

Unmuting MixedClusterClientYamlTestSuiteIT #120462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2025
Merged

Unmuting MixedClusterClientYamlTestSuiteIT #120462

merged 3 commits into from
Jan 20, 2025

Conversation

cbuescher
Copy link
Member

Unmuting MixedClusterClientYamlTestSuiteIT but muting several knn parsing related yaml rest tests instead.

Relates to #119806

@cbuescher
Unmuting MixedClusterClientYamlTestSuiteIT
70fcbc6 
Unmuting MixedClusterClientYamlTestSuiteIT but muting several knn
parsing related yaml rest tests instead.

Relates to elastic#119806
@cbuescher cbuescher added :Search/Search Search-related issues that do not fall into other categories >test-mute Use for PR that only mute tests v8.18.0 labels Jan 20, 2025
@cbuescher cbuescher requested a review from javanna January 20, 2025 10:48
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jan 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

cbuescher
cbuescher commented Jan 20, 2025
View reviewed changes
@cbuescher cbuescher mentioned this pull request Jan 20, 2025
Closed
@cbuescher
Copy link
Member Author

pinging @benwtrent just for awareness that some of the knn stuff still needs fixing on the 8.x branch

@pmpailis
Copy link
Contributor

Given that we added the k param rather recently (#119700) maybe we just need to also ensure that the search.vectors.k_param_supported cluster feature is in place for the tests?

@pmpailis
Copy link
Contributor

I see that we've already done this for #119942
Will setup a PR for the rest of the knn cases as well.

@cbuescher
Copy link
Member Author

@pmpailis thanks

@pmpailis pmpailis mentioned this pull request Jan 20, 2025
Merged
@cbuescher
Copy link
Member Author

Removing the additional mutes since #120466 got merged already.

@cbuescher cbuescher merged commit 0de3d12 into elastic:8.x Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmpailis pmpailis pmpailis approved these changes

@javanna javanna Awaiting requested review from javanna

Assignees

No one assigned

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-mute Use for PR that only mute tests v8.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbuescher @elasticsearchmachine @pmpailis