Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Jan 28, 2025

The same persistent task name should not be registered twice with different executors. This PR adds an assertion for it.

Relates: ES-10533

The same persistent task name should not be registered twice with
different executors. This PR adds an assertion for it.

Relates: ES-10533
@ywangd ywangd added >non-issue :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. v9.0.0 labels Jan 28, 2025
@ywangd ywangd requested a review from nicktindall January 28, 2025 05:51
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Jan 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member Author

ywangd commented Jan 28, 2025

@elasticmachine update branch

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 28, 2025
@ywangd
Copy link
Member Author

ywangd commented Jan 31, 2025

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Jan 31, 2025

@elasticmachine test this please

@ywangd
Copy link
Member Author

ywangd commented Jan 31, 2025

buildkite test this

@ywangd
Copy link
Member Author

ywangd commented Feb 3, 2025

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Feb 3, 2025

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Feb 4, 2025

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit caa4353 into elastic:main Feb 5, 2025
17 checks passed
@ywangd ywangd deleted the assert-no-duplicate-task-executors branch February 5, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants