-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Assert for no duplicate persistent task executor #120984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 6 commits into
elastic:main
from
ywangd:assert-no-duplicate-task-executors
Feb 5, 2025
Merged
Assert for no duplicate persistent task executor #120984
elasticsearchmachine
merged 6 commits into
elastic:main
from
ywangd:assert-no-duplicate-task-executors
Feb 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same persistent task name should not be registered twice with different executors. This PR adds an assertion for it. Relates: ES-10533
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
nicktindall
approved these changes
Jan 28, 2025
Contributor
nicktindall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine test this please |
Member
Author
|
buildkite test this |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Task Management
Issues for anything around the Tasks API - both persistent and node level.
>non-issue
Team:Distributed Coordination
Meta label for Distributed Coordination team
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same persistent task name should not be registered twice with different executors. This PR adds an assertion for it.
Relates: ES-10533