[ES|QL] Fix MapExpression and named parameter related tests in StatementParserTests #121075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionArgumentWithUnsupportedNamedParameterTypes
fang-xing-esql
added
>test
nik9000
reviewed
Jan 30, 2025
| assumeTrue( | ||
| "named parameters for identifiers and patterns require snapshot build", | ||
| EsqlCapabilities.Cap.NAMED_PARAMETER_FOR_FIELD_AND_FUNCTION_NAMES_SIMPLIFIED_SYNTAX.isEnabled() | ||
| ); |
Member
There was a problem hiding this comment.
Doing it this way will cause the whole test to stop. Maybe we're better off wrapping the assertion in an if
Member
Author
There was a problem hiding this comment.
The tests that run only under snapshot are extracted to a separate test.
This was referenced Jan 30, 2025
nik9000
approved these changes
Jan 30, 2025
| assumeTrue( | ||
| "named parameters for identifiers and patterns require snapshot build", | ||
| EsqlCapabilities.Cap.NAMED_PARAMETER_FOR_FIELD_AND_FUNCTION_NAMES_SIMPLIFIED_SYNTAX.isEnabled() | ||
| ); |
Member
Author
|
@elasticmachine update branch |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Member
Author
|
The reported failures below are unrelated, I'll get this merged to unblock #121306 and #121297 elasticsearch-ci/checkPart3 / release-tests |
fang-xing-esql
added a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Jan 30, 2025
…entParserTests (elastic#121075) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]>
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
fang-xing-esql
added a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Jan 30, 2025
…entParserTests (elastic#121075) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b381a1d) # Conflicts: # muted-tests.yml
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
saikatsarkar056
pushed a commit
to saikatsarkar056/elasticsearch
that referenced
this pull request
Jan 30, 2025
…entParserTests (elastic#121075) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 30, 2025
…entParserTests (#121075) (#121330) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b381a1d) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 30, 2025
…entParserTests (#121075) (#121331) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit b381a1d) # Conflicts: # muted-tests.yml
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jan 30, 2025
…entParserTests (elastic#121075) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
…entParserTests (#121075) (#121328) * fix StatementParserTests.testNamedFunctionArgumentInMap, testNamedFunctionArgumentWithUnsupportedNamedParameterTypes * separate snapshot test from release test --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #121020
Resolves: #121047
These two tests -
testNamedFunctionArgumentInMap,testNamedFunctionArgumentWithUnsupportedNamedParameterTypesinStatementParserTestsreference some features that are still under snapshot, add the check toEsqlCapabilitiesin them.