Skip to content

Fix inference update API calls with task_type in body or deployment_id defined #121231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

Fix inference update API calls with task_type in body or deployment_id defined #121231

merged 5 commits into from
Jan 30, 2025

Conversation

@dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Jan 29, 2025 •
edited
Loading

Description

Issue - https://github.com/elastic/ml-team/issues/1467

The update inference API currently has 2 bugs that cause failures when trying to update endpoints:

  1. If the task type is provided in the request body rather than the URL, the parsing logic fails to retrieve the task type.
  2. If the endpoint is linked to a deployment ID that does not match the endpoint ID, the update fails as it attempts to update the non-existent deployment with the endpoint ID as the deployment ID.

This change updates our logic to handle both of these cases.

Testing

  • Unit + Integ tests
  • Tried updating an endpoint with the task type in the URL and in the body
  • Tried updating an endpoint linked to a deployment_id.

@dan-rubinstein dan-rubinstein added >bug :ml Machine learning Team:ML Meta label for the ML team v9.0.0 v8.18.0 labels Jan 29, 2025
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 29, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 29, 2025

Hi @dan-rubinstein, I've created a changelog YAML for you.

@dan-rubinstein dan-rubinstein added v8.17.2 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 29, 2025
@dan-rubinstein dan-rubinstein marked this pull request as ready for review January 29, 2025 21:21
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 29, 2025

Pinging @elastic/ml-core (Team:ML)

davidkyle
davidkyle approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-rubinstein dan-rubinstein added auto-backport Automatically create backport pull requests when merged v8.18.0 and removed v8.19.0 labels Jan 30, 2025
@dan-rubinstein
Copy link
Member Author

dan-rubinstein commented Jan 30, 2025

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein merged commit 011557d into elastic:main Jan 30, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 30, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.17 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
❌ 9.1 The branch "9.1" is invalid or doesn't exist

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121231

dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Jan 30, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
7b2cf0d 
…d defined (elastic#121231)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
@dan-rubinstein dan-rubinstein mentioned this pull request Jan 30, 2025
Merged
dan-rubinstein added a commit that referenced this pull request Jan 30, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
afd5b9f 
…d defined (#121231) (#121320)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Feb 3, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
c18aa2f 
…d defined (elastic#121231)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
@dan-rubinstein dan-rubinstein mentioned this pull request Feb 3, 2025
Merged
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Feb 3, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
b2ad75e 
…d defined (elastic#121231)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
@dan-rubinstein dan-rubinstein mentioned this pull request Feb 3, 2025
Merged
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Feb 3, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
328a117 
…d defined (elastic#121231)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
@jonathan-buttner jonathan-buttner mentioned this pull request Feb 4, 2025
Merged
dan-rubinstein added a commit that referenced this pull request Feb 4, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
4d83a17 
…d defined (#121231) (#121534)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein added a commit that referenced this pull request Feb 4, 2025
@dan-rubinstein @elasticmachine
[8.18] Fix inference update API calls with task_type in body or deplo…
402b84b 
…yment_id defined (#121231) (#121557)

* Fix inference update API calls with task_type in body or deployment_id defined (#121231)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>

* Update docs/changelog/121557.yaml

* Delete docs/changelog/121557.yaml

---------

Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein added a commit that referenced this pull request Feb 4, 2025
@dan-rubinstein @elasticmachine
Fix inference update API calls with task_type in body or deployment_i…
bb7e477 
…d defined (#121231) (#121564)

* Fix inference update API calls with task_type in body or deployment_id defined

* Update docs/changelog/121231.yaml

* Fixing test

* Reuse existing deployment ID retrieval logic

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v8.17.2 v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dan-rubinstein @elasticsearchmachine @davidkyle @elasticmachine