[Inference API] Remove second calculator instance as component and update tests #121284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and cast to concrete instance and make sure it's the correct one for the test.
timgrein
added
>non-issue
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Jan 30, 2025
Collaborator
|
Hi @timgrein, I've created a changelog YAML for you. |
timgrein
added
>non-issue
>test
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Feb 3, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
components.add(calculator)was just needed to makeInferenceServiceNodeLocalRateLimitCalculatorTestswork as these tests explicitly requested a concrete implementation ofInferenceServiceRateLimitCalculator, so it had to be explicitly known to Guice. I've adapted the tests to request the interface instead and check, if it's the correct instance for the test and cast it accordingly (we want to test with the real calculator and not the noop one). This removes the need for adding the calculator two times.I feel like this should be backported? Otherwise we've two cluster state listeners doing the same thing and only one gets injected?