[8.x] ESQL: Enable LOOKUP JOIN in non-snapshot builds (#121193) #121297
Conversation
This effectively releases LOOKUP JOIN into tech preview. Docs will follow in a separate PR. * Enable the lexing/grammar for LOOKUP JOIN in non-snapshot builds. * Remove the grammar for the unsupported | JOIN ... command (without LOOKUP as first keyword). The way the lexer modes work, otherwise we'd also have to enable | JOIN ... syntax on non-snapshot builds and would have to add additional validation to provide appropriate error messages. * Remove grammar for LOOKUP JOIN index AS ... because qualifiers are not yet supported. Otherwise we'd have to put in additional validation as well to prevent such queries. --------- Co-authored-by: Bogdan Pintea <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Nik Everett <[email protected]> (cherry picked from commit 70b397c) # Conflicts: # muted-tests.yml # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.interp # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.java
alex-spies
added
>enhancement
release highlight
auto-merge-without-approval
|
Hi @alex-spies, I've created a changelog YAML for you. Note that since this PR is labelled |
|
the release test failure is the same as the part 2 failure here: #121193 (comment) which we were ok with ignoring then and will here as well. |
|
Check part 3 is also ok - it's almost the same failures in #121193 (comment) which are ok. It has one extra - #121075 - which we're also ok with. |
|
Merging 8.x to pick up the mute for the failure on |
I think I'd really like to get that one in first so we get more comprehensive testing. |
That one's landed in |
|
The packaging test failures seem to be a communication problem between CI and github. They finished and passed. The release test failures line up with #121193 (comment) which we thought we ok then so we believe they are still ok. Should be fixed soon and not blocking this. |
3 participants
Backport
This will backport the following commits from
mainto8.x: