From 5bec32a37628be5c38a0af8e7e644c502e8de63d Mon Sep 17 00:00:00 2001 From: Kostas Krikellas Date: Thu, 30 Jan 2025 15:22:46 +0200 Subject: [PATCH 1/4] Skip tests in rest-compat that fail due to versioning issues --- muted-tests.yml | 2 -- rest-api-spec/build.gradle | 12 ++++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index df39bd09bfa2b..7f3cdf85628ce 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -341,8 +341,6 @@ tests: issue: https://github.com/elastic/elasticsearch/issues/121253 - class: org.elasticsearch.lucene.FullClusterRestartLuceneIndexCompatibilityIT issue: https://github.com/elastic/elasticsearch/issues/121257 -- class: org.elasticsearch.test.rest.ClientYamlTestSuiteIT - issue: https://github.com/elastic/elasticsearch/issues/121269 - class: org.elasticsearch.upgrades.VectorSearchIT method: testBBQVectorSearch {upgradedNodes=1} issue: https://github.com/elastic/elasticsearch/issues/121271 diff --git a/rest-api-spec/build.gradle b/rest-api-spec/build.gradle index 68da320923898..975342c47edef 100644 --- a/rest-api-spec/build.gradle +++ b/rest-api-spec/build.gradle @@ -98,4 +98,16 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task -> task.skipTest("index/91_metrics_no_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") task.skipTest("index/91_metrics_no_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") task.skipTest("logsdb/10_settings/routing path allowed in logs mode with routing on sort fields", "Unknown feature routing.logsb_route_on_sort_fields") + + task.skipTest("search/520_fetch_fields/fetch _seq_no via fields", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("search/90_search_after/_shard_doc sort", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/search with routing", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/noop update", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/80_index_resize/split", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/index with routing over _bulk", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/index with routing", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/update over _bulk", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/90_unsupported_operations/regular update", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/25_id_generation/delete over _bulk", "Skip until versioning between 8.x and 9.x is restored") + task.skipTest("tsdb/20_mapping/exact match object type", "Skip until versioning between 8.x and 9.x is restored") }) From 913ca0355d8f1272789a16b43b836f8414743dc7 Mon Sep 17 00:00:00 2001 From: Kostas Krikellas Date: Thu, 30 Jan 2025 17:16:57 +0200 Subject: [PATCH 2/4] Clean up skipped tests in rest-compat mode --- rest-api-spec/build.gradle | 50 -------------------------------------- 1 file changed, 50 deletions(-) diff --git a/rest-api-spec/build.gradle b/rest-api-spec/build.gradle index 975342c47edef..c627335af6263 100644 --- a/rest-api-spec/build.gradle +++ b/rest-api-spec/build.gradle @@ -60,54 +60,4 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task -> task.skipTest("cat.aliases/10_basic/Deprecated local parameter", "CAT APIs not covered by compatibility policy") task.skipTest("cat.shards/10_basic/Help", "sync_id is removed in 9.0") task.skipTest("search/500_date_range/from, to, include_lower, include_upper deprecated", "deprecated parameters are removed in 9.0") - task.skipTest("logsdb/10_settings/logsdb with default ignore dynamic beyond limit and default sorting", "skip until pr/118968 gets backported") - task.skipTest("logsdb/10_settings/logsdb with default ignore dynamic beyond limit and too low limit", "skip until pr/118968 gets backported") - task.skipTest("logsdb/10_settings/logsdb with default ignore dynamic beyond limit and subobjects false", "skip until pr/118968 gets backported") - task.skipTest("logsdb/10_settings/override sort missing settings", "skip until pr/118968 gets backported") - task.skipTest("logsdb/10_settings/override sort order settings", "skip until pr/118968 gets backported") - task.skipTest("logsdb/10_settings/override sort mode settings", "skip until pr/118968 gets backported") - task.skipTest("search.vectors/41_knn_search_bbq_hnsw/Test knn search", "Scoring has changed in latest versions") - task.skipTest("search.vectors/42_knn_search_bbq_flat/Test knn search", "Scoring has changed in latest versions") - task.skipTest("search.vectors/180_update_dense_vector_type/Test create and update dense vector mapping with bulk indexing", "waiting for #118774 backport") - task.skipTest("search.vectors/160_knn_query_missing_params/kNN query in a bool clause - missing num_candidates", "waiting for #118774 backport") - task.skipTest("search.vectors/110_knn_query_with_filter/Simple knn query", "waiting for #118774 backport") - task.skipTest("search.vectors/160_knn_query_missing_params/kNN search used in nested field - missing num_candidates", "waiting for #118774 backport") - task.skipTest("search.vectors/180_update_dense_vector_type/Test create and update dense vector mapping to int4 with per-doc indexing and flush", "waiting for #118774 backport") - task.skipTest("search.vectors/110_knn_query_with_filter/PRE_FILTER: knn query with internal filter as pre-filter", "waiting for #118774 backport") - task.skipTest("search.vectors/180_update_dense_vector_type/Index, update and merge", "waiting for #118774 backport") - task.skipTest("search.vectors/160_knn_query_missing_params/kNN query with missing num_candidates param - size provided", "waiting for #118774 backport") - task.skipTest("search.vectors/110_knn_query_with_filter/POST_FILTER: knn query with filter from a parent bool query as post-filter", "waiting for #118774 backport") - task.skipTest("search.vectors/120_knn_query_multiple_shards/Aggregations with collected number of docs depends on num_candidates", "waiting for #118774 backport") - task.skipTest("search.vectors/180_update_dense_vector_type/Test create and update dense vector mapping with per-doc indexing and flush", "waiting for #118774 backport") - task.skipTest("search.vectors/110_knn_query_with_filter/PRE_FILTER: knn query with alias filter as pre-filter", "waiting for #118774 backport") - task.skipTest("search.vectors/140_knn_query_with_other_queries/Function score query with knn query", "waiting for #118774 backport") - task.skipTest("search.vectors/130_knn_query_nested_search/nested kNN search inner_hits size > 1", "waiting for #118774 backport") - task.skipTest("search.vectors/110_knn_query_with_filter/PRE_FILTER: pre-filter across multiple aliases", "waiting for #118774 backport") - task.skipTest("search.vectors/160_knn_query_missing_params/kNN search in a dis_max query - missing num_candidates", "waiting for #118774 backport") - task.skipTest("search.highlight/30_max_analyzed_offset/Plain highlighter with max_analyzed_offset < 0 should FAIL", "semantics of test has changed") - task.skipTest("indices.create/10_basic/Create lookup index", "default auto_expand_replicas was removed") - task.skipTest("indices.create/10_basic/Create lookup index with one shard", "default auto_expand_replicas was removed") - task.skipTest("range/20_synthetic_source/Double range", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("range/20_synthetic_source/Float range", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("range/20_synthetic_source/Integer range", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("range/20_synthetic_source/IP range", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("range/20_synthetic_source/Long range", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("range/20_synthetic_source/Date range Rounding Fixes", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("index/92_metrics_auto_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("index/92_metrics_auto_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("index/91_metrics_no_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("index/91_metrics_no_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") - task.skipTest("logsdb/10_settings/routing path allowed in logs mode with routing on sort fields", "Unknown feature routing.logsb_route_on_sort_fields") - - task.skipTest("search/520_fetch_fields/fetch _seq_no via fields", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("search/90_search_after/_shard_doc sort", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/search with routing", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/noop update", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/80_index_resize/split", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/index with routing over _bulk", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/index with routing", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/update over _bulk", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/90_unsupported_operations/regular update", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/25_id_generation/delete over _bulk", "Skip until versioning between 8.x and 9.x is restored") - task.skipTest("tsdb/20_mapping/exact match object type", "Skip until versioning between 8.x and 9.x is restored") }) From fccf85fec770155fe4013a7d906f33ea546eb514 Mon Sep 17 00:00:00 2001 From: Kostas Krikellas Date: Thu, 30 Jan 2025 17:48:39 +0200 Subject: [PATCH 3/4] restore some --- rest-api-spec/build.gradle | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/rest-api-spec/build.gradle b/rest-api-spec/build.gradle index e7da4bde9eac0..8f746d6444fd6 100644 --- a/rest-api-spec/build.gradle +++ b/rest-api-spec/build.gradle @@ -62,4 +62,14 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task -> task.skipTest("cat.aliases/10_basic/Deprecated local parameter", "CAT APIs not covered by compatibility policy") task.skipTest("cat.shards/10_basic/Help", "sync_id is removed in 9.0") task.skipTest("search/500_date_range/from, to, include_lower, include_upper deprecated", "deprecated parameters are removed in 9.0") + task.skipTest("range/20_synthetic_source/Double range", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("range/20_synthetic_source/Float range", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("range/20_synthetic_source/Integer range", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("range/20_synthetic_source/IP range", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("range/20_synthetic_source/Long range", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("range/20_synthetic_source/Date range Rounding Fixes", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("index/92_metrics_auto_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("index/92_metrics_auto_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("index/91_metrics_no_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") + task.skipTest("index/91_metrics_no_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0") }) From 3ea91b233af1ed4955daf0f29f992b2b7ca68c97 Mon Sep 17 00:00:00 2001 From: Kostas Krikellas Date: Thu, 30 Jan 2025 18:11:04 +0200 Subject: [PATCH 4/4] restore some --- rest-api-spec/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/rest-api-spec/build.gradle b/rest-api-spec/build.gradle index 8f746d6444fd6..0069e34fe949e 100644 --- a/rest-api-spec/build.gradle +++ b/rest-api-spec/build.gradle @@ -62,6 +62,7 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task -> task.skipTest("cat.aliases/10_basic/Deprecated local parameter", "CAT APIs not covered by compatibility policy") task.skipTest("cat.shards/10_basic/Help", "sync_id is removed in 9.0") task.skipTest("search/500_date_range/from, to, include_lower, include_upper deprecated", "deprecated parameters are removed in 9.0") + task.skipTest("search.highlight/30_max_analyzed_offset/Plain highlighter with max_analyzed_offset < 0 should FAIL", "semantics of test has changed") task.skipTest("range/20_synthetic_source/Double range", "_source.mode mapping attribute is no-op since 9.0.0") task.skipTest("range/20_synthetic_source/Float range", "_source.mode mapping attribute is no-op since 9.0.0") task.skipTest("range/20_synthetic_source/Integer range", "_source.mode mapping attribute is no-op since 9.0.0")