Fix PolicyManagerTests after package move #121304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Jan 30, 2025
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this.
Contributor
Author
|
I didn't bother with |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Jan 30, 2025
* Fix PolicyManagerTests after package move * Unmute
This was referenced Jan 30, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Jan 30, 2025
* Fix PolicyManagerTests after package move * Unmute
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 30, 2025
…#121341) * Add single flag entitlement validation (#121234) This adds basic flag entitlement validation when creating PolicyManager. If a module has the same flag entitlement as part of it's policy multiple times we will throw an IllegalArgumentException. With this validation we can safely assume FileEntitlement is the only one we currently have that allows multiple entitlements in a policy. * Refactor: separate package for entitlement records (#121204) * Fix PolicyManagerTests after package move (#121304) * Fix PolicyManagerTests after package move * Unmute --------- Co-authored-by: Jack Conradson <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
…#121340) * Add single flag entitlement validation (#121234) This adds basic flag entitlement validation when creating PolicyManager. If a module has the same flag entitlement as part of it's policy multiple times we will throw an IllegalArgumentException. With this validation we can safely assume FileEntitlement is the only one we currently have that allows multiple entitlements in a policy. * Refactor: separate package for entitlement records (#121204) * Fix PolicyManagerTests after package move (#121304) * Fix PolicyManagerTests after package move * Unmute --------- Co-authored-by: Jack Conradson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #121204 and #121234 conflicted.