[8.18] ESQL: Enable LOOKUP JOIN in non-snapshot builds (#121193) #121306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively releases LOOKUP JOIN into tech preview. Docs will follow in a separate PR. * Enable the lexing/grammar for LOOKUP JOIN in non-snapshot builds. * Remove the grammar for the unsupported | JOIN ... command (without LOOKUP as first keyword). The way the lexer modes work, otherwise we'd also have to enable | JOIN ... syntax on non-snapshot builds and would have to add additional validation to provide appropriate error messages. * Remove grammar for LOOKUP JOIN index AS ... because qualifiers are not yet supported. Otherwise we'd have to put in additional validation as well to prevent such queries. --------- Co-authored-by: Bogdan Pintea <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Nik Everett <[email protected]>
alex-spies
added
>feature
backport
auto-merge-without-approval
Member
|
The part 2 failure is the same one we ignored in #121193 (comment) - and we're ok continuing to ignore it here. |
Member
|
Check part 3 is also ok - it's almost the same failures in #121193 (comment) which are ok. It has one extra - #121075 - which we're also ok with. |
Member
|
run elasticsearch-ci/checkPart4 / release-tests |
Member
|
run elasticsearch-ci/checkPart4 |
Member
|
@elasticmachine, run elasticsearch-ci/checkPart4 / release-tests |
Member
|
|
Member
|
I've retried it. |
Member
|
The 8.16bwc failure looks like #121350 The other failures line up with #121193 (comment) which we consider non-blocking. They should be fixed soon and are unrelated to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #121193