Improve resolve/cluster yaml test #121315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>test
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
quux00
force-pushed
the
fix/resolve-cluster-yaml
branch
from
c8c6e9f to
60c63fc
Compare
quux00
changed the title
Contributor
Author
|
buildkite test this |
smalyshev
reviewed
Jan 30, 2025
| --- | ||
| "Resolve cluster with no index expression": | ||
| - requires: | ||
| cluster_features: ["gte_v8.18.0"] |
Contributor
There was a problem hiding this comment.
Shouldn't we use capabilities instead of direct version numbers? I'm still a bit confused in which case what is used.
Contributor
Author
There was a problem hiding this comment.
Probably a good follow-on ticket. I've not added any capabilities for the stuff we've been doing so far, but also not sure the yaml tests support capability based checks. This is the standard way to do it for yaml tests (see higher up in the yaml doc for the 8.13 restrictions).
smalyshev
approved these changes
Jan 30, 2025
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Jan 31, 2025
Updated indices.resolve_cluster.json to match new resolve/cluster spec. Added new test for the no-index-expression endpoint. Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
Updated indices.resolve_cluster.json to match new resolve/cluster spec. Added new test for the no-index-expression endpoint. Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass.
This was referenced Feb 24, 2025
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
pushed a commit
to pquentin/elasticsearch
that referenced
this pull request
Feb 24, 2025
Updated indices.resolve_cluster.json to match new resolve/cluster spec. Added new test for the no-index-expression endpoint. Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass. (cherry picked from commit 3fafb5f)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Updated indices.resolve_cluster.json to match new resolve/cluster spec. Added new test for the no-index-expression endpoint. Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass. (cherry picked from commit 3fafb5f) Co-authored-by: Michael Peterson <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Updated indices.resolve_cluster.json to match new resolve/cluster spec. Added new test for the no-index-expression endpoint. Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass. (cherry picked from commit 3fafb5f) Co-authored-by: Michael Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated indices.resolve_cluster.json to match new resolve/cluster spec.
Added new test for the no-index-expression endpoint.
Adjust syntax in 10_basic_resolve_cluster.yml syntax fix so that the elasticsearch-specification validation tests pass.