Skip to content

Update ESRestTestCase's ROLLUP_REQUESTS_OPTIONS #121335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Update ESRestTestCase's ROLLUP_REQUESTS_OPTIONS #121335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,16 @@ public abstract class ESRestTestCase extends ESTestCase {
private static final String EXPECTED_ROLLUP_WARNING_MESSAGE =
"The rollup functionality will be removed in Elasticsearch 10.0. See docs for more information.";
public static final RequestOptions.Builder ROLLUP_REQUESTS_OPTIONS = RequestOptions.DEFAULT.toBuilder().setWarningsHandler(warnings -> {
// Either no warning, because of bwc integration test OR
// the expected warning, because on current version
if (warnings.isEmpty()) {
return false;
} else if (warnings.size() == 1 && EXPECTED_ROLLUP_WARNING_MESSAGE.equals(warnings.get(0))) {
return false;
} else {
return true;
// Sometimes multiple rollup deprecation warnings. Transport actions can be invoked multiple time on different nodes.
for (String warning : warnings) {
if (EXPECTED_ROLLUP_WARNING_MESSAGE.equals(warning) == false) {
return true;
}
}
return false;
}
});

Expand Down