Skip to content

Fix testResetAllocationFailuresOnNodeShutdown #121378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix testResetAllocationFailuresOnNodeShutdown #121378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99a15f5
Fix AllocationFailuresResetOnShutdownIT#testResetAllocationFailuresOn…
pxsalehi Jan 31, 2025
0e26d33
Merge branch 'main' into ps250131-fix-testResetAllocationFailuresOnNo…
pxsalehi Feb 3, 2025
d4240d9
Merge branch 'main' into ps250131-fix-testResetAllocationFailuresOnNo…
pxsalehi Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,6 @@ tests:
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: test {p0=nodes.stats/11_indices_metrics/indices mappings exact count test for indices level}
issue: https://github.com/elastic/elasticsearch/issues/120950
- class: org.elasticsearch.xpack.shutdown.AllocationFailuresResetOnShutdownIT
method: testResetAllocationFailuresOnNodeShutdown
issue: https://github.com/elastic/elasticsearch/issues/121129
- class: org.elasticsearch.xpack.security.authc.jwt.JwtRealmSingleNodeTests
method: testActivateProfileForJWT
issue: https://github.com/elastic/elasticsearch/issues/120983
Expand Down
10 changes: 5 additions & 5 deletions ...lusterTest/java/org/elasticsearch/xpack/shutdown/AllocationFailuresResetOnShutdownIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,18 +175,18 @@ public void beforeIndexShardCreated(ShardRouting routing, Settings indexSettings

prepareCreate("index1", indexSettings(1, 0)).execute();

// await all relocation attempts are exhausted
// await all allocation attempts are exhausted
var maxAttempts = MaxRetryAllocationDecider.SETTING_ALLOCATION_MAX_RETRY.get(Settings.EMPTY);
ensureRed("index1");
{
assertBusy(() -> {
var state = safeGet(clusterAdmin().prepareState(TEST_REQUEST_TIMEOUT).execute()).getState();
var index = state.getRoutingTable().index("index1");
assertNotNull(index);
var shard = index.shard(0).primaryShard();
assertNotNull(shard);
assertNotNull(shard.unassignedInfo());
assertThat(maxAttempts, equalTo(shard.unassignedInfo().failedAllocations()));
}
});

failAllocation.set(false);

Expand Down Expand Up @@ -240,13 +240,13 @@ public void beforeIndexShardCreated(ShardRouting routing, Settings indexSettings
// await all allocation attempts are exhausted
var maxAttempts = MaxRetryAllocationDecider.SETTING_ALLOCATION_MAX_RETRY.get(Settings.EMPTY);
ensureRed("index1");
{
assertBusy(() -> {
var state = safeGet(clusterAdmin().prepareState(TEST_REQUEST_TIMEOUT).execute()).getState();
var shard = state.getRoutingTable().index("index1").shard(0).primaryShard();
assertNotNull(shard);
assertNotNull(shard.unassignedInfo());
assertThat(maxAttempts, equalTo(shard.unassignedInfo().failedAllocations()));
}
});

failAllocation.set(false);

Expand Down