Skip sending ShardActiveRequest checks in stateless nodes #121387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stateless node rely on an external blob store to persist data, therefor it's not necessary to go through such checks when a shard store should be deleted. Closes ES-10577
fcofdez
added
>non-issue
:Distributed Indexing/Store
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
fcofdez
commented
Jan 31, 2025
| } | ||
|
|
||
| private void deleteShardStoreOnApplierThread(ShardId shardId, long clusterStateVersion) { | ||
| clusterService.getClusterApplierService() |
There was a problem hiding this comment.
I think it wouldn't be necessary to run this on the applier thread, but I wanted to keep the changes minimal.
elasticsearchmachine
added
the
serverless-linked
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stateless node rely on an external blob store to persist data, therefor it's not necessary to go through such checks when a shard store should be deleted.
Closes ES-10577