Refactor InnerHitsRewriteContext into a more generic PerDocumentQueryRewriteContext #121405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RewriteContext The DFS and highlight phases require rewriting the Lucene query outside of the query phase. However, if the query contains a k-NN query, this triggers a nearest neighbor search on the entire shard, which is unnecessary in these phases since computing top-N results is not required. This change builds upon elastic#104006, applying the same transformation used for nested inner hits. As a result, DFS and highlight phases avoid wasting time and resources on costly nearest neighbor searches. Note: The explain and matched query phases are also affected but still require the nearest neighbor search for accurate results, so they remain unchanged for now.
jimczi
added
>enhancement
:Search Relevance/Vectors
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @jimczi, I've created a changelog YAML for you. |
…xt' into per_document_rewrite_query_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DFS and highlight phases require rewriting the Lucene query outside of the query phase. However, if the query contains a k-NN query, this triggers a nearest neighbor search on the entire shard, which is unnecessary in these phases since computing top-N results is not required.
This change builds upon #104006, applying the same transformation used for nested inner hits.
As a result, DFS and highlight phases avoid wasting time and resources on costly nearest neighbor searches.
Note: The explain and matched query phases are also affected but still require the nearest neighbor search for accurate results, so they remain unchanged for now.