Skip to content

[Inference API] Fix node local rate limit calculator tests for non-snapshot builds #121527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2025
+5 −2
Merged

[Inference API] Fix node local rate limit calculator tests for non-snapshot builds #121527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
379284b
Fix tests for non-snapshot builds
timgrein Feb 3, 2025
25ab2cd
Correct message
timgrein Feb 3, 2025
5c83eb9
Fix checkstyle
timgrein Feb 3, 2025
65cbdac
Merge branch 'main' into fix-inference-node-local-rate-limit-calculat…
timgrein Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,6 @@ tests:
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: test {p0=search.vectors/42_knn_search_int4_flat/Vector similarity with filter only}
issue: https://github.com/elastic/elasticsearch/issues/121412
- class: org.elasticsearch.xpack.inference.common.InferenceServiceNodeLocalRateLimitCalculatorTests
issue: https://github.com/elastic/elasticsearch/issues/121294
- class: org.elasticsearch.xpack.ml.integration.ClassificationIT
method: testDependentVariableIsAliasToKeyword
issue: https://github.com/elastic/elasticsearch/issues/121492
Expand Down
5 changes: 5 additions & 0 deletions ...asticsearch/xpack/inference/common/InferenceServiceNodeLocalRateLimitCalculatorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ public class InferenceServiceNodeLocalRateLimitCalculatorTests extends ESIntegTe

public void setUp() throws Exception {
super.setUp();
assumeTrue(
Copy link
Contributor

@jonathan-buttner jonathan-buttner Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 👍

"If inference_cluster_aware_rate_limiting_feature_flag_enabled=false we'll fallback to "
+ "NoopNodeLocalRateLimitCalculator, which shouldn't be tested by this class.",
InferenceAPIClusterAwareRateLimitingFeature.INFERENCE_API_CLUSTER_AWARE_RATE_LIMITING_FEATURE_FLAG.isEnabled()
);
}

public void testInitialClusterGrouping_Correct() throws Exception {
Expand Down