Fail the reindex data stream task if any document fails to reindex #121591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
.../main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java
Show resolved
Hide resolved
parkertimmins
approved these changes
Feb 4, 2025
This was referenced Feb 4, 2025
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Feb 4, 2025
Collaborator
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the reindex data streams code, we do not currently check whether every document has succeeded. A ReindexAction succeeds even if all documents fail. This means that we swap the potentially-empty destination index into the data stream, and then delete the source index containing data that was not moved over to the destination index. This PR changes it so that the entire task fails if there are any failed documents, and the source index is not deleted.