Entitlement policies correct handling of prefixes that are not directories #121598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Feb 4, 2025
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
Closed
rjernst
reviewed
Feb 5, 2025
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 5, 2025
…ories (elastic#121598) * Fix FileAccessTree for prefixes that aren't parents * Support backslashes * Whoops, nio * Move normalization responsibility to FileEntitlement * Normalize to native separators * Avoid forbidden API
Collaborator
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 5, 2025
…ories (elastic#121598) * Fix FileAccessTree for prefixes that aren't parents * Support backslashes * Whoops, nio * Move normalization responsibility to FileEntitlement * Normalize to native separators * Avoid forbidden API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect
foofrom matchingfooddespite being a prefixBackslash rationale
To the greatest extent possible, we want things to "just work" on Windows. Policy files should not fail to parse, or work incorrectly, due solely to the use of the forward slash as a file separator on Windows.
The simplest solution turned out to be to use
toAbsolutePath()to turn all slashes into platform-default slashes. This behaviour isn't documented intoAbsolutePath()'s javadocs, but it's the behaviour I observed on Windows.