From 9ff5afabfc4568c4474bc2387bfd8f822153f5db Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Fri, 7 Feb 2025 10:19:34 -0500 Subject: [PATCH] Aggs: Comment on deprecated execution mode This adds a comment to `execution_mode: global_ordinals_hash` explaining that we're not going to remove it so we don't break anyone. --- .../bucket/terms/SignificantTermsAggregatorFactory.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTermsAggregatorFactory.java b/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTermsAggregatorFactory.java index 080cac9cbfb85..c3ed7a6dd5dfb 100644 --- a/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTermsAggregatorFactory.java +++ b/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTermsAggregatorFactory.java @@ -422,6 +422,10 @@ public static ExecutionMode fromString(String value, final DeprecationLogger dep if ("global_ordinals".equals(value)) { return GLOBAL_ORDINALS; } else if ("global_ordinals_hash".equals(value)) { + /* + * We have no plans to remove this so we don't break anyone, no matter + * how few people still use this or how long it's been deprecated. + */ deprecationLogger.warn( DeprecationCategory.AGGREGATIONS, "global_ordinals_hash",