[Inference API] Rename model_id prop to model in EIS sparse inference request body #122272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demjened
added
>enhancement
:SearchOrg/Inference
elasticsearchmachine
added
Team:SearchOrg
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Hi @demjened, I've created a changelog YAML for you. |
…mjened/elasticsearch into demjened/eis-sparse-model-id-property
maxjakob
approved these changes
Feb 12, 2025
This was referenced Feb 12, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other APIs we're renaming the
model_idproperty tomodelin the outgoing sparse embedding inference request to Elastic Inference Service (EIS). EIS has already been updated (and deployed) to accept either notation.