Simplify comparators in InternalOrder #122330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random find :) We can build slightly more compact (and likely also fasster) iterators while using less code for these. Also, no need to create method references as a way of casting.
original-brownbear
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
original-brownbear
added
the
auto-backport
Contributor
Author
|
Thanks Ignacio! |
Collaborator
💚 Backport successful
|
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 12, 2025
We can build slightly more compact (and likely also faster) iterators while using less code for these. Also, no need to create method references as a way of casting.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random find :)
We can build slightly more compact (and likely also faster by avoiding the iterator creation for every comparison and such) iterators while using less code for these. Also, no need to create method references as a way of casting.