Fix ArrayIndexOutOfBoundsException in ShardBulkInferenceActionFilter #122538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>bug
auto-backport
Mikep86
requested review from
Samiul-TheSoccerFan,
dan-rubinstein,
jimczi and
kderusso
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Collaborator
|
Hi @Mikep86, I've created a changelog YAML for you. |
kderusso
reviewed
Feb 13, 2025
...t/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java
Show resolved
Hide resolved
jimczi
approved these changes
Feb 14, 2025
kderusso
approved these changes
Feb 14, 2025
...t/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java
Show resolved
Hide resolved
dan-rubinstein
approved these changes
Feb 14, 2025
This was referenced Feb 18, 2025
Merged
Collaborator
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Feb 18, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Feb 18, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Feb 18, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Feb 18, 2025
…lastic#122538) (cherry picked from commit 229d392) # Conflicts: # x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java
Contributor
Author
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Feb 18, 2025
…lastic#122538) (cherry picked from commit 229d392) # Conflicts: # x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
…Filter (#122538) (#122853) * Fix ArrayIndexOutOfBoundsException in ShardBulkInferenceActionFilter (#122538) (cherry picked from commit 229d392) # Conflicts: # x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java * Fix compilation & test failures
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
…Filter (#122538) (#122854) * Fix ArrayIndexOutOfBoundsException in ShardBulkInferenceActionFilter (#122538) (cherry picked from commit 229d392) # Conflicts: # x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java * Fix compilation & test failures
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the error handlers in
ShardBulkInferenceActionFiltercould cause anArrayIndexOutOfBoundsExceptionto be thrown. Large bulk requests get split into multiple batches, causing their global index in the bulk request and local index in the batch to diverge. TheShardBulkInferenceActionFiltererror handling logic did not account for this.