Update TransportNodesCapabilitiesAction for V9 #122609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-ivanov-es
added
>enhancement
:Core/Infra/REST API
Collaborator
|
Hi @alexey-ivanov-es, I've created a changelog YAML for you. |
| // Fixme: lies! all lies! | ||
| out.writeVInt(8); | ||
| // out.writeVInt(restApiVersion.major); | ||
| if (restApiVersionMajor == null) { |
Contributor
Author
There was a problem hiding this comment.
Should this be a new TransportVersion? Format of the message doesn't change, but there is a change in how value is handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for REST API version V9 in Node Capabilities actions.
If no version is specified in the REST request, the transport message will contain 0 as the rest version field, and nodes processing the request will interpret it as their current
RestApiVersion.If the REST request includes version explicitly, it will be sent as-is in the transport message, and nodes processing the request will attempt to deserialize it. In a mixed cluster scenario, if a node does not recognize the requested version, it will respond that it does not support the capability.
PR adding support for reading the 0 as rest version from transport message to v8: #122613