Update TransportNodesCapabilitiesAction for V9 #122613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-ivanov-es
added
>enhancement
:Core/Infra/REST API
Collaborator
|
Hi @alexey-ivanov-es, I've created a changelog YAML for you. |
| restApiVersion = RestApiVersion.forMajor(in.readVInt()); | ||
| byte versionFromMessage = (byte) in.readVInt(); | ||
| // V9 can send IMPLICIT_REST_API_VERSION | ||
| restApiVersionMajor = (versionFromMessage != IMPLICIT_REST_API_VERSION) ? versionFromMessage : null; |
Contributor
Author
There was a problem hiding this comment.
8.18/8.19 should be able to understand message sent by v9 node containing either 9 or 0
| out.writeCollection(parameters, StreamOutput::writeString); | ||
| out.writeCollection(capabilities, StreamOutput::writeString); | ||
| out.writeVInt(restApiVersion.major); | ||
| out.writeVInt(restApiVersionMajor); |
Contributor
Author
There was a problem hiding this comment.
8.18/8.19 send only 7 or 8 here, any other node they can form cluster with understands it
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #122609 introduces the ability for a v9 server to send 0 as the REST version in NodeCapabilitiesRequest when it is implicit. This PR ensures that v8.18/v8.19 can correctly read and handle such requests but does not change how v8 nodes send their NodeCapabilitiesRequest. As a result, v8 nodes will still be able to communicate with both v9 and older v8 nodes.