Fix redact processor arraycopy bug #122640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @joegallo, I've created a changelog YAML for you. |
davidkyle
approved these changes
Feb 16, 2025
| */ | ||
| String redactMatches(byte[] utf8Bytes, String redactStartToken, String redactEndToken) { | ||
| var merged = mergeOverlappingReplacements(replacementPositions); | ||
| int longestPatternName = merged.stream().mapToInt(r -> r.patternName.getBytes(StandardCharsets.UTF_8).length).max().getAsInt(); |
Member
There was a problem hiding this comment.
longestPatternName probably was a name once but now its the number of bytes in the longest name. Suggest longestPatternSize
Contributor
Author
There was a problem hiding this comment.
👍 on renaming, but since it's the max() of the length of the patternName(s), I went with maxPatternNameLength.
joegallo
added
the
auto-backport
This was referenced Feb 17, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 17, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 17, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 17, 2025
Collaborator
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 17, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a byte array buffer size issue that can come up sometimes (it can be undersized) -- we need to account for the size of the prefix and suffix when doing that math on the buffer size.