-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove shard changes and add retention lease REST APIs #122754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
salvatore-campagna
merged 8 commits into
elastic:main
from
salvatore-campagna:fix/remove-shard-changes-action
Feb 18, 2025
Merged
Remove shard changes and add retention lease REST APIs #122754
salvatore-campagna
merged 8 commits into
elastic:main
from
salvatore-campagna:fix/remove-shard-changes-action
Feb 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Feb 18, 2025
Member
martijnvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
When this is merged, #118800 can also be closed.
Maybe also backport this change to 9.0? I don't think this got back ported to 8.x branch?
This was referenced Feb 18, 2025
Collaborator
💚 Backport successful
|
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>non-issue
:StorageEngine/Logs
You know, for Logs
Team:StorageEngine
v9.0.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially introduced two REST APIs to facilitate testing of shard recovery using synthetic source:
However, we later found that using local CCR with the auto-follow pattern in Rally nightly provided a
better benchmarking approach for synthetic source recovery. Since these APIs are no longer necessary,
this PR removes them, streamlining the codebase and avoiding exposing APIs which are not expected to
be used outside Elasticsearch.