Skip to content

Conversation

@salvatore-campagna
Copy link
Contributor

We initially introduced two REST APIs to facilitate testing of shard recovery using synthetic source:

  • Shard changes
  • Add retention lease

However, we later found that using local CCR with the auto-follow pattern in Rally nightly provided a
better benchmarking approach for synthetic source recovery. Since these APIs are no longer necessary,
this PR removes them, streamlining the codebase and avoiding exposing APIs which are not expected to
be used outside Elasticsearch.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When this is merged, #118800 can also be closed.
Maybe also backport this change to 9.0? I don't think this got back ported to 8.x branch?

@salvatore-campagna salvatore-campagna added v9.0.0 auto-backport Automatically create backport pull requests when merged labels Feb 18, 2025
@salvatore-campagna salvatore-campagna merged commit cb62b44 into elastic:main Feb 18, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :StorageEngine/Logs You know, for Logs Team:StorageEngine v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants