Remove TransportDownsampleIndexerAction
#122756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
|
Does this need to be backported to 9.0? |
Member
I don't think it has to be back ported. Maybe we should do this for consistency? |
Contributor
|
Yes, i meant just for consistency. |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Feb 20, 2025
(cherry picked from commit 7f7967b) # Conflicts: # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/TransportDownsampleIndexerAction.java
salvatore-campagna
added a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #97557, we adopted the persistent task framework to execute downsampling tasks. Previously, these tasks were executed as regular, non-persistent tasks. In both cases, the master node was responsible for orchestrating and coordinating task execution. However, starting with version 8.10, the orchestration mechanism changed as part of the transition to the persistent task framework.
With the introduction of persistent tasks,
TransportDownsampleActionnow usesPersistentTasksServiceto request the execution of a persistent downsampling task. Instead of assigning the task directly to the node hosting the primary shard and going throughTransportDownsampleIndexerAction, the request is now handled byDownsampleShardPersistentTaskExecutor, which takes full ownership of task execution and lifecycle management.For backward compatibility, we initially retained
TransportDownsampleIndexerAction. Depending on the master node's version, one of two orchestration mechanisms was selected:Now that newer versions of Elasticsearch no longer need to maintain backward compatibility with 8.10, we can safely remove the class responsible for the old, non-persistent downsampling task execution.