StressSearchServiceReaperIT_unmute_test

[drempapis]

Fix for the error described below in StressSearchServiceReaperIT

2024-11-13T06:00:50,891][ERROR][o.e.t.LeakTracker        ] [[Cleaner-0]] LEAK: resource was not cleaned up before it was garbage-collected.
Recent access records: 
Created at:
	in [TEST-StressSearchServiceReaperIT.testStressReaper-seed#[348419C7C7365FE]][testStressReaper]
	org.elasticsearch.action.search.ArraySearchPhaseResults.<init>(ArraySearchPhaseResults.java:28)
	org.elasticsearch.action.search.QueryPhaseResultConsumer.<init>(QueryPhaseResultConsumer.java:86)
	org.elasticsearch.action.search.SearchPhaseController.newSearchPhaseResults(SearchPhaseController.java:841)
	org.elasticsearch.action.search.TransportSearchAction$AsyncSearchActionProvider.newSearchPhase(TransportSearchAction.java:1500)

closes #115816

[elasticsearchmachine]

Pinging @elastic/es-search-foundations (Team:Search Foundations)

[original-brownbear]

See my inline comment, the problem is elsewhere, test code looks good to me.

[original-brownbear]

No sorry this can't be it. The builder is resolved and the response released right away by assertHitCountAndNoFailures. If we're leaking it's not because we're leaking the actual search response, we're leaking some intermediary objects and likely never get to the search response here.

See this line in the failure:

	org.elasticsearch.action.search.ArraySearchPhaseResults.<init>(ArraySearchPhaseResults.java:28)

we're leaking the intermediary per-shard response array, we're not leaking a fully built response.

[drempapis]

Thank you, @original-brownbear, for the feedback. After a private discussion, we decided it was safe to unmute the test.

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
✅	9.0
❌	8.17	Commit could not be cherrypicked due to conflicts
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	8.x	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122793